From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: xpad - fix rumble on Xbox One controllers with 2015 firmware Date: Tue, 31 May 2016 15:32:05 -0700 Message-ID: <20160531223205.GA28457@dtor-ws> References: <574E0E07.9090303@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:34284 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837AbcEaWcJ (ORCPT ); Tue, 31 May 2016 18:32:09 -0400 Received: by mail-pf0-f193.google.com with SMTP id c84so249375pfc.1 for ; Tue, 31 May 2016 15:32:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <574E0E07.9090303@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Cameron Gutman Cc: linux-input@vger.kernel.org, rojtberg@gmail.com Hi Cameron, On Tue, May 31, 2016 at 05:19:51PM -0500, Cameron Gutman wrote: > Xbox One controllers that shipped with or were upgraded to the 2015 > firmware discard the current rumble packets we send. This patch changes > the Xbox One rumble packet to a form that the newer firmware will accept. But what do we do with the older devices? Thanks. > > It is based on changes made to support newer Xbox One controllers in > the SteamOS brewmaster-4.1 kernel branch. > > Signed-off-by: Cameron Gutman > --- > drivers/input/joystick/xpad.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > index 804dbcc..923c572 100644 > --- a/drivers/input/joystick/xpad.c > +++ b/drivers/input/joystick/xpad.c > @@ -1031,17 +1031,17 @@ static int xpad_play_effect(struct input_dev *dev, void *data, struct ff_effect > > case XTYPE_XBOXONE: > packet->data[0] = 0x09; /* activate rumble */ > - packet->data[1] = 0x08; > + packet->data[1] = 0x00; > packet->data[2] = xpad->odata_serial++; > - packet->data[3] = 0x08; /* continuous effect */ > - packet->data[4] = 0x00; /* simple rumble mode */ > - packet->data[5] = 0x03; /* L and R actuator only */ > - packet->data[6] = 0x00; /* TODO: LT actuator */ > - packet->data[7] = 0x00; /* TODO: RT actuator */ > + packet->data[3] = 0x09; > + packet->data[4] = 0x00; > + packet->data[5] = 0x0F; > + packet->data[6] = 0x00; > + packet->data[7] = 0x00; > packet->data[8] = strong / 512; /* left actuator */ > packet->data[9] = weak / 512; /* right actuator */ > - packet->data[10] = 0x80; /* length of pulse */ > - packet->data[11] = 0x00; /* stop period of pulse */ > + packet->data[10] = 0xFF; > + packet->data[11] = 0x00; > packet->data[12] = 0x00; > packet->len = 13; > packet->pending = true; > -- > 2.7.4 -- Dmitry