From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/3] input: touchscreen: mxs-lradc: Add support for touchscreen Date: Wed, 1 Jun 2016 11:29:49 -0700 Message-ID: <20160601182949.GE4114@dtor-ws> References: <61fe1da2e8d82921f3222ec939047b6823f695e1.1461930102.git.ksenija.stanojevic@gmail.com> <20160429233616.GA13361@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:36061 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbcFAS3y (ORCPT ); Wed, 1 Jun 2016 14:29:54 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Ksenija =?utf-8?Q?Stanojevi=C4=87?= Cc: linux-kernel@vger.kernel.org, Lee Jones , linux-input@vger.kernel.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Marek =?utf-8?B?VmHFoXV0?= , linux-iio@vger.kernel.org, Harald Geyer On Sat, May 28, 2016 at 07:46:07PM +0200, Ksenija Stanojevi=C4=87 wrote= : > On Sat, Apr 30, 2016 at 1:36 AM, Dmitry Torokhov > wrote: > > Hi Ksenija, > > > > On Fri, Apr 29, 2016 at 01:49:11PM +0200, Ksenija Stanojevic wrote: > >> + > >> + mxs_lradc_ts_hw_init(ts); > >> + for (i =3D 0; i < lradc->irq_count; i++) { > >> + ret =3D devm_request_irq(dev, lradc->irq[i], > >> + mxs_lradc_ts_handle_irq, > > > > Hmm, if you have several interrupts handled by the same interrupt > > handler you'd need some locking there. >=20 > same interrupt handler can run concurrently only on multi cores, so > why do we need locking? We do not necessarily need it on single core (unless someone will turn it int threaded IRQ down the road), but adding it costs almost nothing and will ensure that the driver will continue working even if block is moved to multi-core SOC in the future... Thanks. --=20 Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html