From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>,
dtor@chromium.org, bleung@chromium.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
aduggan@synaptics.com, k.kozlowski@samsung.com,
dianders@chromium.org, gabriele.mzt@gmail.com,
linux-input@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c_hid: enable i2c-hid devices to suspend/resume asynchronously
Date: Fri, 3 Jun 2016 09:56:03 +0200 [thread overview]
Message-ID: <20160603075603.GE23234@mail.corp.redhat.com> (raw)
In-Reply-To: <573D2900.6090903@linux.intel.com>
On May 19 2016 or thereabouts, Fu, Zhonghui wrote:
> i2c-hid devices' suspend/resume are usually time-consuming process.
> For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet
> takes about 160ms for suspending and 120ms for resuming. This patch
> enables i2c-hid devices to suspend/resume asynchronously. This will
> take advantage of multicore and speed up system suspend/resume process.
>
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> ---
In regard with the discussion:
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> drivers/hid/i2c-hid/i2c-hid.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 2e021ba..cc41e1e 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1020,6 +1020,7 @@ static int i2c_hid_probe(struct i2c_client *client,
> pm_runtime_get_noresume(&client->dev);
> pm_runtime_set_active(&client->dev);
> pm_runtime_enable(&client->dev);
> + device_enable_async_suspend(&client->dev);
>
> ret = i2c_hid_fetch_hid_descriptor(ihid);
> if (ret < 0)
> -- 1.7.1
>
next prev parent reply other threads:[~2016-06-03 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 2:46 [PATCH] i2c_hid: enable i2c-hid devices to suspend/resume asynchronously Fu, Zhonghui
2016-05-23 8:22 ` Mika Westerberg
2016-05-24 10:24 ` Jiri Kosina
[not found] ` <CAE_wzQ-Rwpf3Cb8cpw11s=rcRTMZ5kpod7jLAhF84A82CLaVcA@mail.gmail.com>
2016-06-01 2:04 ` Fu, Zhonghui
2016-06-03 7:56 ` Benjamin Tissoires [this message]
2016-06-06 8:41 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603075603.GE23234@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=aduggan@synaptics.com \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=gabriele.mzt@gmail.com \
--cc=jikos@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=zhonghui.fu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).