Re: [PATCH] HID: multitouch: add support for Type Cover Pro 3

[Benjamin Tissoires <benjamin.tissoires@redhat.com>]

On Jun 17 2016 or thereabouts, Jiri Kosina wrote:
> On Fri, 17 Jun 2016, Dennis Chen wrote:
> 
> > Include Microsoft Type Cover 3 support into hid-multitouch.c
> > Allow touchpad device to have multitouch functionality.
> > 
> > Signed-off-by: Dennis Chen <barracks510@gmail.com>
> > ---
> >  drivers/hid/Kconfig          |  1 +
> >  drivers/hid/hid-multitouch.c | 14 ++++++++++++++
> >  2 files changed, 15 insertions(+)
> > 
> > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> > index 5646ca4..5af0603 100644
> > --- a/drivers/hid/Kconfig
> > +++ b/drivers/hid/Kconfig
> > @@ -530,6 +530,7 @@ config HID_MULTITOUCH
> >  	  - IrTouch Infrared USB panels
> >  	  - LG Display panels (Dell ST2220Tc)
> >  	  - Lumio CrystalTouch panels
> > +	  - Microsoft Type Cover 3 touchpad
> >  	  - MosArt dual-touch panels
> >  	  - Panasonic multitouch panels
> >  	  - PenMount dual touch panels
> > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> > index c741f5e..f052ed2 100644
> > --- a/drivers/hid/hid-multitouch.c
> > +++ b/drivers/hid/hid-multitouch.c
> > @@ -1377,6 +1377,20 @@ static const struct hid_device_id mt_devices[] = {
> >  		MT_USB_DEVICE(USB_VENDOR_ID_ILITEK,
> >  			USB_DEVICE_ID_ILITEK_MULTITOUCH) },
> >  
> > +	/* Microsoft Type Cover 3 touchpad */
> > +	{ .driver_data = MT_CLS_EXPORT_ALL_INPUTS,
> > +		MT_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
> > +			USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) },
> > +	{ .driver_data = MT_CLS_EXPORT_ALL_INPUTS,
> > +		MT_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
> > +			USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2) },
> > +	{ .driver_data = MT_CLS_EXPORT_ALL_INPUTS,
> > +		MT_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
> > +			USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
> > +	{ .driver_data = MT_CLS_EXPORT_ALL_INPUTS,
> > +		MT_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
> > +			USB_DEVICE_ID_MS_TYPE_COVER_3) },
> > +
> >  	/* MosArt panels */
> >  	{ .driver_data = MT_CLS_CONFIDENCE_MINUS_ONE,
> 
> This would mean that both hid-multitouch and hid-microsoft would claim 
> support for this device, which isn't really going to provide consistent 
> user experience. Is MT_CLS_EXPORT_ALL_INPUTS sufficient to provide 
> complete functionality by hid-multitouch? If so, the support from 
> hid-microsoft should be dropped.

Also, please see if the series with the 2 following patches is not
sufficient enough:
http://www.spinics.net/lists/linux-input/msg44576.html
http://www.spinics.net/lists/linux-input/msg44577.html

If you just adapt the second patch to add your ids, it should hopefully
be working (though the surface book is not for some unknown reasons
yet).

Cheers,
Benjamin

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html