linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Patrick Lessard <Patrick.Lessard@cogeco.com>, kt.liao@emc.com.tw
Cc: linux-input@vger.kernel.org
Subject: Re: New Elantech touchpad version?
Date: Mon, 20 Jun 2016 11:21:10 -0700	[thread overview]
Message-ID: <20160620182110.GD22426@dtor-ws> (raw)
In-Reply-To: <4D0DB74D8481894EB236F640F391FC7E0107F5CF6C@TRPMEXMBX1.cogeco.com>

Hi Patrick,

On Mon, Jun 20, 2016 at 06:10:41PM +0000, Patrick Lessard wrote:
> Hello!
> 
> First, thank you very much for creating a driver for the Elantech touchpads. Very appeciated.
> 
> I’ve contacted one of the original author, Arjan Opmeer and he directed me to you. (those 2 email addresses actually)
> 
> I just bought a HP Pavilion 14-ab057ca laptop and I think it uses a new version of the Elantech touchpad.
> 
> On linux, when I boot, I get this message :
> 
> « psmouse serio1: elantech: unknown hardware version, aborting... »
> 
> By looking at the kernel driver code in elantech.c below, I might try a quick patch and add a case higher than 14, compile and try it.

Looking at HP site it seems that at least some batches of this laptop
are shipping with Elan touchpads.

KT, do we need to expand the list in elantech_set_properties() to
include more IC types?

> 
> If succesfull, could you include a fix in the near future?
> 
> Are you still maintaining this driver?
> 
> How should I proceed?
> 
> Thank you very much for your attention.
> 
> Patrick.
> 
> 
> Code snippet :
> 
> ….
> 
> static int elantech_set_properties(struct elantech_data *etd)
> {
>         /* This represents the version of IC body. */
>         int ver = (etd->fw_version & 0x0f0000) >> 16;
> 
>         /* Early version of Elan touchpads doesn't obey the rule. */
>         if (etd->fw_version < 0x020030 || etd->fw_version == 0x020600)
>                etd->hw_version = 1;
>         else {
>                switch (ver) {
>                case 2:
>                case 4:
>                        etd->hw_version = 2;
>                        break;
>                case 5:
>                        etd->hw_version = 3;
>                        break;
>                case 6:
>                case 7:
>                case 8:
>                case 9:
>                case 10:
>                case 13:
>                case 14:
>                        etd->hw_version = 4;
>                        break;
>                default:
>                        return -1;
>                }
>         }
> 

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

       reply	other threads:[~2016-06-20 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4D0DB74D8481894EB236F640F391FC7E0107F5CF6C@TRPMEXMBX1.cogeco.com>
2016-06-20 18:21 ` Dmitry Torokhov [this message]
2016-06-20 23:53   ` RE : New Elantech touchpad version? Patrick Lessard
2016-06-21  1:38     ` Patrick Lessard
2016-06-21  3:24       ` Patrick Lessard
2016-06-21 12:01         ` 廖崇榮
2016-06-21 12:19           ` Patrick Lessard
2016-06-21 14:02   ` 廖崇榮

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160620182110.GD22426@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=Patrick.Lessard@cogeco.com \
    --cc=kt.liao@emc.com.tw \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).