From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Alps I2C HID Touchpad-Stick support Date: Mon, 20 Jun 2016 23:36:55 -0700 Message-ID: <20160621063655.GA26764@dtor-ws> References: <1466070357-5315-1-git-send-email-masaki.ota@jp.alps.com> <20160621033925.GB35864@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:36792 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbcFUGit (ORCPT ); Tue, 21 Jun 2016 02:38:49 -0400 Received: by mail-pa0-f42.google.com with SMTP id wo6so3263657pac.3 for ; Mon, 20 Jun 2016 23:36:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Masaki Ota Cc: Masaki Ota <012nexus@gmail.com>, "jikos@kernel.org" , "benjamin.tissorires@redhat.com" , "peter.hutterer@who-t.net" , "hdegoede@redhat.com" , "linux-input@vger.kernel.org" , Naoki Saito Hi Masaki, On Tue, Jun 21, 2016 at 04:43:05AM +0000, Masaki Ota wrote: > Hi, Dmitry, > > > +struct u1_dev *priv; > I do not understand why you need this global. You can allocate arbitrary memory in probe() and you actually already do that, why do you need second copy? > > Yes, actually I don't want to use global, but I want to use it in alps_raw_event() for StickPointer. > Do you have any idea? What is wrong with using input2 pointer in hdata (provided you set it up properly when probing the device)? Thanks. -- Dmitry