From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Date: Sat, 25 Jun 2016 08:53:49 -0700 Message-ID: <20160625155349.GD17812@dtor-ws> References: <1466759887-25394-1-git-send-email-narmstrong@baylibre.com> <1466759887-25394-3-git-send-email-narmstrong@baylibre.com> <20160624220748.GB11719@dtor-ws> <576E41FC.1080102@baylibre.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <576E41FC.1080102-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Neil Armstrong Cc: andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Rob Herring List-Id: linux-input@vger.kernel.org On Sat, Jun 25, 2016 at 10:34:04AM +0200, Neil Armstrong wrote: > On 06/25/2016 12:07 AM, Dmitry Torokhov wrote: > > On Fri, Jun 24, 2016 at 11:18:04AM +0200, Neil Armstrong wrote: > >> In order to support pwrkey for Qualcomm MDM9615 SoC, add support > >> for the pm8018 pwrkey in pmic8xxx-pwrkey. > >> > >> Reviewed-by: Bjorn Andersson > >> Signed-off-by: Neil Armstrong > > > > NAK. > > Hi Dmitry, > > Actually, the new compatible string make sense, because the driver is compatible with the > "pm8018" pwrkey but from a system point of view, it's not a pm8921 pwrkey, hence the new > compatible string. A lot of systems note this fact in DTS, but not require driver changes, by specifying several compatible strings: compatible = "nvidia,tegra114-sdhci", "nvidia,tegra30-sdhci"; compatible = "fsl,imx6q-i2c", "fsl,imx21-i2c"; compatible = "rockchip,rk3036-timer", "rockchip,rk3288-timer"; > > Rob Herring was very clear with me with this policy, and it will simplify further driver Could I get a pointer to this discussion so I can educate myself better about DT policies? > architecture change since it will not imply devicetree changes anymore. Would we need the driver changes? What are the differences in power key functionality between 8018 and 8921? > > My point of view is that the devicetree describes the hardware and need to have SoC specific > compatible string since it describes the actual silicon, and drivers must make sure to handle > all the SoC or family variants using the compatible string and the match data. No, the compatible string means that the hardware is *compatible* with something. It does not mean that we need to adjust driver every time a company pumps out a new package including said hardware. Thanks. -- Dmitry -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.