From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes Date: Fri, 8 Jul 2016 14:08:24 -0700 Message-ID: <20160708210824.GE28589@dtor-ws> References: <1465903215-2351-1-git-send-email-martink@posteo.de> <20160623171835.GE32561@dtor-ws> <246597fa-6a85-1128-853d-3ebdf6f41032@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <246597fa-6a85-1128-853d-3ebdf6f41032-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Martin Kepplinger Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote: > Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: > > Hi Martin, > > > > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: > >> static int pegasus_reset_resume(struct usb_interface *intf) > >> { > >> + struct pegasus *pegasus = usb_get_intfdata(intf); > >> + > >> + if (pegasus->dev->users) > >> + pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE); > >> + > >> return pegasus_resume(intf); > > > > Hmm, we need to take input mutex when using pegasus->dev->users, how > > about the version below instead? > > > > Thanks. > > > > Sorry for the delay, give me a few more days to test and confirm this or > come up with a final patch. Martin, did you have time to try out this version of the patch? Thanks! -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html