From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hutterer Subject: Re: [PATCH] Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE Date: Thu, 14 Jul 2016 15:57:59 +1000 Message-ID: <20160714055759.GA4889@jelly.local> References: <20160111035151.GA24743@jelly.redhat.com> <20160111081233.GA27512@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from leo.clearchain.com ([199.73.29.74]:65087 "EHLO mail.clearchain.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbcGNF6G (ORCPT ); Thu, 14 Jul 2016 01:58:06 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Ping Cheng Cc: Dmitry Torokhov , "linux-input@vger.kernel.org" , Benjamin Tissoires , Jason Gerecke , Aaron Armstrong Skomra On Wed, Jul 13, 2016 at 05:22:30PM -0700, Ping Cheng wrote: > On Wednesday, July 13, 2016, Dmitry Torokhov wrote: > > > > On Mon, Jan 11, 2016 at 12:12 AM, Dmitry Torokhov > > wrote: > > > On Mon, Jan 11, 2016 at 01:51:51PM +1000, Peter Hutterer wrote: > > >> As of e0361b70175f0cd6199dd9ed6679632de73973d4 > > >> Input: wacom_w8001 - split the touch and pen devices into two devices > > >> the touch events aren't multiplexed over the same device anymore, the use of > > >> ABS_MT_TOOL_TYPE is superfluous. And even before then it only ever sent > > >> MT_TOOL_TYPE_FINGER anyway. > > >> > > >> Signed-off-by: Peter Hutterer > > > > > > Applied, thank you. > > > > Hmm, so I applied that but removal of input_mt_report_slot_state() > > means that we do not generate tacking IDs for the contacts. > > You are right. I have a set of patches to clean up the code. It is > still under testing/reviewing... > > > > > Revert? > > It may be quicker to revert this one now. I'll submit the clean up set later. yeah, I agree and we found another bug with these devices. It'll be easier to merge the fixed set. Cheers, Peter