From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Peter Hutterer <peter.hutterer@who-t.net>
Cc: Ping Cheng <pinglinux@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Jason Gerecke <killertofu@gmail.com>,
Aaron Armstrong Skomra <skomra@gmail.com>
Subject: Re: [PATCH] Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE
Date: Thu, 14 Jul 2016 09:42:29 -0700 [thread overview]
Message-ID: <20160714164229.GA17106@dtor-ws> (raw)
In-Reply-To: <20160714055759.GA4889@jelly.local>
On Thu, Jul 14, 2016 at 03:57:59PM +1000, Peter Hutterer wrote:
> On Wed, Jul 13, 2016 at 05:22:30PM -0700, Ping Cheng wrote:
> > On Wednesday, July 13, 2016, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > >
> > > On Mon, Jan 11, 2016 at 12:12 AM, Dmitry Torokhov
> > > <dmitry.torokhov@gmail.com> wrote:
> > > > On Mon, Jan 11, 2016 at 01:51:51PM +1000, Peter Hutterer wrote:
> > > >> As of e0361b70175f0cd6199dd9ed6679632de73973d4
> > > >> Input: wacom_w8001 - split the touch and pen devices into two devices
> > > >> the touch events aren't multiplexed over the same device anymore, the use of
> > > >> ABS_MT_TOOL_TYPE is superfluous. And even before then it only ever sent
> > > >> MT_TOOL_TYPE_FINGER anyway.
> > > >>
> > > >> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
> > > >
> > > > Applied, thank you.
> > >
> > > Hmm, so I applied that but removal of input_mt_report_slot_state()
> > > means that we do not generate tacking IDs for the contacts.
> >
> > You are right. I have a set of patches to clean up the code. It is
> > still under testing/reviewing...
> >
> > >
> > > Revert?
> >
> > It may be quicker to revert this one now. I'll submit the clean up set later.
>
> yeah, I agree and we found another bug with these devices. It'll be easier
> to merge the fixed set.
OK, reverted (and revert marked for stable). I added your acks to the
revert commit.
Thanks!
--
Dmitry
prev parent reply other threads:[~2016-07-14 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 3:51 [PATCH] Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE Peter Hutterer
2016-01-11 8:12 ` Dmitry Torokhov
2016-07-14 0:09 ` Dmitry Torokhov
2016-07-14 0:22 ` Ping Cheng
2016-07-14 5:57 ` Peter Hutterer
2016-07-14 16:42 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714164229.GA17106@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=pinglinux@gmail.com \
--cc=skomra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).