From: Wolfram Sang <wsa@the-dreams.de>
To: Brian Norris <briannorris@chromium.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Olof Johansson <olof@lixom.net>,
Brian Norris <computersforpeace@gmail.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Enric Balletbo <enric.balletbo@collabora.co.uk>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()
Date: Mon, 25 Jul 2016 22:43:13 +0200 [thread overview]
Message-ID: <20160725204313.GA1698@katana> (raw)
In-Reply-To: <1469470451-111822-2-git-send-email-briannorris@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote:
> cros_ec_cmd_xfer returns success status if the command transport
> completes successfully, but the execution result is incorrectly ignored.
> In many cases, the execution result is assumed to be successful, leading
> to ignored errors and operating on uninitialized data.
>
> We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these
> problems. Let's use it.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
I agree with Dmitry about Thierry pushing the patch. So:
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-25 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 18:14 [PATCH 0/2] cros_ec: utilize cros_ec_cmd_xfer_status() Brian Norris
2016-07-25 18:14 ` [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer() Brian Norris
2016-07-25 18:31 ` kbuild test robot
2016-07-25 19:45 ` Javier Martinez Canillas
2016-07-25 20:43 ` Wolfram Sang [this message]
2016-07-25 20:48 ` Brian Norris
2016-07-26 9:14 ` Thierry Reding
2016-07-26 18:38 ` Brian Norris
2016-07-28 14:15 ` Thierry Reding
2016-07-25 18:14 ` [PATCH 2/2] Input: cros_ec_keyb - " Brian Norris
2016-07-25 18:28 ` Dmitry Torokhov
2016-07-25 18:38 ` kbuild test robot
2016-07-25 19:46 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725204313.GA1698@katana \
--to=wsa@the-dreams.de \
--cc=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.co.uk \
--cc=gwendal@chromium.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=olof@lixom.net \
--cc=shawnn@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).