linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Baole Ni <baolex.ni@intel.com>
Cc: dmitry.torokhov@gmail.com, hal.rosenstock@gmail.com,
	dledford@redhat.com, sean.hefty@intel.com, bp@alien8.de,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	haibo.chen@freescale.com, andrey.gelman@compulab.co.il,
	afd@ti.com, javier@osg.samsung.com, chuansheng.liu@intel.com
Subject: Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 15:31:50 +0100	[thread overview]
Message-ID: <20160802143150.GC10376@sirena.org.uk> (raw)
In-Reply-To: <20160802105711.703-1-baolex.ni@intel.com>

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

On Tue, Aug 02, 2016 at 06:57:11PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

Please split these up and send them independently to the relevant
maintainers with sensible subject lines - a single 1000+ patch series is
far too large and you're CCing random people so it's hard to tell which
patches are relevant (for example the batch I'm replying to here are for
the input subsystem which I don't maintain so I'm not 100% sure why I'm
being copied here).

With this sort of thing it's often best to send one series per directory
or something similar.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-08-02 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 10:57 [PATCH 0290/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 14:31 ` Mark Brown [this message]
2016-08-02 14:51   ` Andrew F. Davis
2016-08-02 17:27 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802143150.GC10376@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=afd@ti.com \
    --cc=andrey.gelman@compulab.co.il \
    --cc=baolex.ni@intel.com \
    --cc=bp@alien8.de \
    --cc=chuansheng.liu@intel.com \
    --cc=dledford@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=haibo.chen@freescale.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=javier@osg.samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).