From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Mika Penttilä" <mika.penttila@nextfour.com>,
"Tammy Tseng" <tammy_tseng@sis.com>,
"Yuger Yu" <yuger_yu@sis.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T
Date: Thu, 4 Aug 2016 08:20:05 -0700 [thread overview]
Message-ID: <20160804152005.GA5504@dtor-ws> (raw)
In-Reply-To: <20160804130758.1253722-1-arnd@arndb.de>
On Thu, Aug 04, 2016 at 03:07:06PM +0200, Arnd Bergmann wrote:
> The newly added sis_i2c driver fails to link without the CRC_ITU_T
> driver enabled:
>
> drivers/input/touchscreen/sis_i2c.o: In function `sis_ts_irq_handler':
> sis_i2c.c:(.text+0xc0): undefined reference to `crc_itu_t'
>
> This adds a Kconfig select statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a485cb037fe6 ("Input: add driver for SiS 9200 family I2C touchscreen controllers")
Thank you Arnd.
> ---
> drivers/input/touchscreen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 8d893cefb0e3..2fb1f430a431 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -1074,6 +1074,7 @@ config TOUCHSCREEN_SILEAD
> config TOUCHSCREEN_SIS_I2C
> tristate "SiS 9200 family I2C touchscreen"
> depends on I2C
> + select CRC_ITU_T
> depends on GPIOLIB || COMPILE_TEST
> help
> This enables support for SiS 9200 family over I2C based touchscreens.
> --
> 2.9.0
>
--
Dmitry
prev parent reply other threads:[~2016-08-04 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 13:07 [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T Arnd Bergmann
2016-08-04 15:20 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804152005.GA5504@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@nextfour.com \
--cc=tammy_tseng@sis.com \
--cc=yuger_yu@sis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).