* [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T
@ 2016-08-04 13:07 Arnd Bergmann
2016-08-04 15:20 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-08-04 13:07 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Mika Penttilä, Tammy Tseng, Yuger Yu, Arnd Bergmann,
linux-input, linux-kernel
The newly added sis_i2c driver fails to link without the CRC_ITU_T
driver enabled:
drivers/input/touchscreen/sis_i2c.o: In function `sis_ts_irq_handler':
sis_i2c.c:(.text+0xc0): undefined reference to `crc_itu_t'
This adds a Kconfig select statement.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: a485cb037fe6 ("Input: add driver for SiS 9200 family I2C touchscreen controllers")
---
drivers/input/touchscreen/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 8d893cefb0e3..2fb1f430a431 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -1074,6 +1074,7 @@ config TOUCHSCREEN_SILEAD
config TOUCHSCREEN_SIS_I2C
tristate "SiS 9200 family I2C touchscreen"
depends on I2C
+ select CRC_ITU_T
depends on GPIOLIB || COMPILE_TEST
help
This enables support for SiS 9200 family over I2C based touchscreens.
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T
2016-08-04 13:07 [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T Arnd Bergmann
@ 2016-08-04 15:20 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2016-08-04 15:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mika Penttilä, Tammy Tseng, Yuger Yu, linux-input,
linux-kernel
On Thu, Aug 04, 2016 at 03:07:06PM +0200, Arnd Bergmann wrote:
> The newly added sis_i2c driver fails to link without the CRC_ITU_T
> driver enabled:
>
> drivers/input/touchscreen/sis_i2c.o: In function `sis_ts_irq_handler':
> sis_i2c.c:(.text+0xc0): undefined reference to `crc_itu_t'
>
> This adds a Kconfig select statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a485cb037fe6 ("Input: add driver for SiS 9200 family I2C touchscreen controllers")
Thank you Arnd.
> ---
> drivers/input/touchscreen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 8d893cefb0e3..2fb1f430a431 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -1074,6 +1074,7 @@ config TOUCHSCREEN_SILEAD
> config TOUCHSCREEN_SIS_I2C
> tristate "SiS 9200 family I2C touchscreen"
> depends on I2C
> + select CRC_ITU_T
> depends on GPIOLIB || COMPILE_TEST
> help
> This enables support for SiS 9200 family over I2C based touchscreens.
> --
> 2.9.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-04 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-04 13:07 [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T Arnd Bergmann
2016-08-04 15:20 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).