From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Robert Dolca <robert.dolca@intel.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Hans de Goede <hdegoede@redhat.com>,
Daniel Jansen <djaniboe@gmail.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: silead - remove some dead code
Date: Thu, 4 Aug 2016 08:25:00 -0700 [thread overview]
Message-ID: <20160804152500.GC5504@dtor-ws> (raw)
In-Reply-To: <20160804052859.GI775@mwanda>
On Thu, Aug 04, 2016 at 08:28:59AM +0300, Dan Carpenter wrote:
> buf[0] is an unsigned char. touch_nr is an int. The test for negative
> here doesn't make sense so I have removed it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thank you.
>
> diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
> index 5f55167..7379fe1 100644
> --- a/drivers/input/touchscreen/silead.c
> +++ b/drivers/input/touchscreen/silead.c
> @@ -147,9 +147,6 @@ static void silead_ts_read_data(struct i2c_client *client)
> }
>
> touch_nr = buf[0];
> - if (touch_nr < 0)
> - return;
> -
> if (touch_nr > data->max_fingers) {
> dev_warn(dev, "More touches reported then supported %d > %d\n",
> touch_nr, data->max_fingers);
--
Dmitry
prev parent reply other threads:[~2016-08-04 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 5:28 [patch] Input: silead - remove some dead code Dan Carpenter
2016-08-04 15:25 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804152500.GC5504@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=djaniboe@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=robert.dolca@intel.com \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).