From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [patch] Input: silead - remove some dead code Date: Thu, 4 Aug 2016 08:25:00 -0700 Message-ID: <20160804152500.GC5504@dtor-ws> References: <20160804052859.GI775@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f66.google.com ([209.85.220.66]:33080 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754729AbcHDPZp (ORCPT ); Thu, 4 Aug 2016 11:25:45 -0400 Content-Disposition: inline In-Reply-To: <20160804052859.GI775@mwanda> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dan Carpenter Cc: Robert Dolca , Henrik Rydberg , Hans de Goede , Daniel Jansen , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Aug 04, 2016 at 08:28:59AM +0300, Dan Carpenter wrote: > buf[0] is an unsigned char. touch_nr is an int. The test for negative > here doesn't make sense so I have removed it. > > Signed-off-by: Dan Carpenter Applied, thank you. > > diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c > index 5f55167..7379fe1 100644 > --- a/drivers/input/touchscreen/silead.c > +++ b/drivers/input/touchscreen/silead.c > @@ -147,9 +147,6 @@ static void silead_ts_read_data(struct i2c_client *client) > } > > touch_nr = buf[0]; > - if (touch_nr < 0) > - return; > - > if (touch_nr > data->max_fingers) { > dev_warn(dev, "More touches reported then supported %d > %d\n", > touch_nr, data->max_fingers); -- Dmitry