From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: devicetree <devicetree@vger.kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
linux-input@vger.kernel.org, "Sean Cross" <xobs@kosagi.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] input: touchscreen: Remove duplicate ft6236 driver
Date: Fri, 5 Aug 2016 19:22:43 -0700 [thread overview]
Message-ID: <20160806022243.GB20562@dtor-ws> (raw)
In-Reply-To: <72101a2a-ccf0-b0bc-3859-50a43f990027@i2se.com>
On Fri, Aug 05, 2016 at 05:07:20PM +0200, Stefan Wahren wrote:
> Hi Hans,
>
> Am 05.08.2016 um 09:24 schrieb Hans de Goede:
> >The new(ish) ft6236 simply re-implements the M09 protocol of the
> >(much) older edt-ft5x06.c driver.
> >
> >This commit removes this duplicate driver and adds the i2c ids and
> >dt compatible string to the edt-ft5x06.c driver to keep compatibility.
>
> i think only remove of the driver is incorrect here.
>
> Since there are two similar but still different DT bindings
>
> Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
>
> Documentation/devicetree/bindings/input/touchscreen/focaltech-ft6236.txt
>
> the DT handling of edt-ft5x06.c needs to be extended and then
> finally driver and binding could be removed.
I believe Hans made sure edt-ft5x06.c can handle focaltech-ft6236
bindings. Do you see a discrepancy?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2016-08-06 2:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 7:24 [PATCH 0/1] input: touchscreen: Remove duplicate ft6236 driver Hans de Goede
2016-08-05 7:24 ` [PATCH v3] " Hans de Goede
[not found] ` <1470381871-4086-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-08-05 15:07 ` Stefan Wahren
2016-08-06 2:22 ` Dmitry Torokhov [this message]
2016-08-06 10:00 ` Hans de Goede
2016-08-06 12:43 ` Noralf Trønnes
2016-08-06 13:15 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160806022243.GB20562@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=stefan.wahren@i2se.com \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).