From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 2/3] Input: touchscreen: mc13783_ts: Remove deprecated create_singletheread_workqueue Date: Mon, 15 Aug 2016 18:53:59 -0400 Message-ID: <20160815225359.GD3672@mtj.duckdns.org> References: <0fec13b74998216009d338fad3e143a3488e0b4a.1471151622.git.bhaktipriya96@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:32888 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752356AbcHOWyG (ORCPT ); Mon, 15 Aug 2016 18:54:06 -0400 Content-Disposition: inline In-Reply-To: <0fec13b74998216009d338fad3e143a3488e0b4a.1471151622.git.bhaktipriya96@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Bhaktipriya Shridhar Cc: Dmitry Torokhov , Hans de Goede , Pali =?iso-8859-1?Q?Roh=E1r?= , Chris Diamand , Stefan Assmann , Richard Pospesel , Lars-Peter Clausen , Takashi Iwai , patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, Aug 14, 2016 at 10:55:30AM +0530, Bhaktipriya Shridhar wrote: > The workqueue "workqueue" has a single workitem(&priv->work) and hence > doesn't require ordering. Also, it is not being used on a memory reclaim > path. Hence, the singlethreaded workqueue has been replaced with the use > of system_wq. > > System workqueues have been able to handle high level of concurrency > for a long time now and hence it's not required to have a singlethreaded > workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue > created with create_singlethread_workqueue(), system_wq allows multiple > work items to overlap executions even on the same CPU; however, a > per-cpu workqueue doesn't have any CPU locality or global ordering > guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > Workitem is sync cancelled in mc13783_ts_remove() to ensure that there > are no workitems pending when the driver is disconnected. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun