From: ulrik.debie-os@e2big.org
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] input/mouse/elantech.c: Fix Lenovo version typo
Date: Mon, 22 Aug 2016 22:48:09 +0200 [thread overview]
Message-ID: <20160822204809.GA14500@lantern> (raw)
In-Reply-To: <1471862832-4631-1-git-send-email-marcos.souza.org@gmail.com>
Hi Marcos,
You're missing the Signed-off-by: line; see
https://www.kernel.org/doc/Documentation/SubmittingPatches
But besides that, indeed this was a typo by me and your patch results in what it should have been in the first place.
Reviewed-by: Ulrik De Bie <ulrik.debie-os@e2big.org>
Thanks,
Ulrik
On Mon, Aug 22, 2016 at 07:47:12AM -0300, Marcos Paulo de Souza wrote:
> Date: Mon, 22 Aug 2016 07:47:12 -0300
> From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> To: linux-input@vger.kernel.org
> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Subject: [PATCH] input/mouse/elantech.c: Fix Lenovo version typo
> X-Mailer: git-send-email 2.7.4
> X-Mailing-List: linux-input@vger.kernel.org
>
> ---
> drivers/input/mouse/elantech.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index 08e252a..1b51961 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -1134,7 +1134,7 @@ static int elantech_get_resolution_v4(struct psmouse *psmouse,
> * System76 Pangolin 0x250f01 ? 2 hw buttons
> * (*) + 3 trackpoint buttons
> * (**) + 0 trackpoint buttons
> - * Note: Lenovo L430 and Lenovo L430 have the same fw_version/caps
> + * Note: Lenovo L430 and Lenovo L530 have the same fw_version/caps
> */
> static void elantech_set_buttonpad_prop(struct psmouse *psmouse)
> {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-08-22 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 10:47 [PATCH] input/mouse/elantech.c: Fix Lenovo version typo Marcos Paulo de Souza
2016-08-22 20:48 ` ulrik.debie-os [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822204809.GA14500@lantern \
--to=ulrik.debie-os@e2big.org \
--cc=linux-input@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox