From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Chris Diamand" <chris@diamand.org>,
"Stefan Assmann" <sassmann@kpanic.de>,
"Richard Pospesel" <pospeselr@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Takashi Iwai" <tiwai@suse.de>, "Tejun Heo" <tj@kernel.org>,
patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread_workqueue
Date: Tue, 23 Aug 2016 14:01:33 -0700 [thread overview]
Message-ID: <20160823210133.GF6712@dtor-ws> (raw)
In-Reply-To: <e062d8979274f279bf6e6181c321647ac193146d.1471151622.git.bhaktipriya96@gmail.com>
On Sun, Aug 14, 2016 at 10:56:38AM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion. The workqueue "ts_workq" has been identity converted.
>
> It queues work items viz &wm->ts_reader and &wm->pen_event_work which map
> to wm97xx_pen_irq_worker (handles a pen down interrupt) and
> wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence,
> an ordered dedicated workqueue has been used.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/wm97xx-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
> index 1534e9b..c0af844 100644
> --- a/drivers/input/touchscreen/wm97xx-core.c
> +++ b/drivers/input/touchscreen/wm97xx-core.c
> @@ -500,7 +500,7 @@ static int wm97xx_ts_input_open(struct input_dev *idev)
> {
> struct wm97xx *wm = input_get_drvdata(idev);
>
> - wm->ts_workq = create_singlethread_workqueue("kwm97xx");
> + wm->ts_workq = alloc_ordered_workqueue("kwm97xx", WQ_MEM_RECLAIM);
> if (wm->ts_workq == NULL) {
> dev_err(wm->dev,
> "Failed to create workqueue\n");
> --
> 2.1.4
>
--
Dmitry
next prev parent reply other threads:[~2016-08-23 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-14 5:19 [PATCH 0/3] Remove usages of deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-08-14 5:23 ` [PATCH 1/3] Input: psmouse: Remove deprecated create_singletheread_workqueue Bhaktipriya Shridhar
2016-08-15 22:53 ` Tejun Heo
2016-08-23 20:51 ` Dmitry Torokhov
2016-08-14 5:25 ` [PATCH 2/3] Input: touchscreen: mc13783_ts: " Bhaktipriya Shridhar
2016-08-15 22:53 ` Tejun Heo
2016-08-23 20:53 ` Dmitry Torokhov
2016-08-14 5:26 ` [PATCH 3/3] Input: wm97xx: " Bhaktipriya Shridhar
2016-08-15 8:53 ` Charles Keepax
2016-08-15 22:53 ` Tejun Heo
2016-08-23 21:01 ` Dmitry Torokhov [this message]
2016-08-23 21:02 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823210133.GF6712@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bhaktipriya96@gmail.com \
--cc=chris@diamand.org \
--cc=hdegoede@redhat.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pospeselr@gmail.com \
--cc=sassmann@kpanic.de \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).