From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
pali.rohar@gmail.com, hdegoede@redhat.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH] Input: focaltech - mark focaltech_set_resolution() static
Date: Mon, 5 Sep 2016 10:33:46 -0700 [thread overview]
Message-ID: <20160905173346.GB12404@dtor-ws> (raw)
In-Reply-To: <5089277.G6NWohFGP5@wuerfel>
On Wed, Aug 31, 2016 at 11:58:50AM +0200, Arnd Bergmann wrote:
> On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]
> >
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks it 'static'.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2016-09-05 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 8:37 [PATCH] Input: focaltech - mark focaltech_set_resolution() static Baoyou Xie
2016-08-31 9:58 ` Arnd Bergmann
2016-09-05 17:33 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905173346.GB12404@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).