From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dennis Wassenberg <dennis.wassenberg@secunet.com>
Cc: linux-input@vger.kernel.org, linux-sound@vger.kernel.org,
alsa-devel@alsa-project.org, tiwai@suse.de, lukas@wunner.de,
Andrew Duggan <aduggan@synaptics.com>,
perex@perex.cz, david.henningsson@canonical.com,
vinod.koul@intel.com, hui.wang@canonical.com,
rafael.j.wysocki@intel.com, jikos@kernel.org
Subject: Re: [PATCH 2/4] HID: add device id for Lenovo X1 Tablet Cover
Date: Mon, 12 Sep 2016 17:53:35 +0200 [thread overview]
Message-ID: <20160912155335.GE25951@mail.corp.redhat.com> (raw)
In-Reply-To: <f04a30b2-5128-fb60-a653-329a61d86366@secunet.com>
On Sep 12 2016 or thereabouts, Dennis Wassenberg wrote:
> Add device id for Lenovo X1 Tablet Cover
>
> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
> ---
quick comment:
this patch should be squashed with the next one where you add support of
this device to the hid-lenovo module.
Cheers,
Benjamin
> drivers/hid/hid-core.c | 1 +
> drivers/hid/hid-ids.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 6add0b6..ba6a200 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2111,6 +2111,7 @@ void hid_disconnect(struct hid_device *hdev)
> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE2) },
> { HID_USB_DEVICE(USB_VENDOR_ID_RAZER, USB_DEVICE_ID_RAZER_BLADE_14) },
> { HID_USB_DEVICE(USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM6533) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X1_COVER) },
> { }
> };
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 3466f0d..1f08fb5 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -615,6 +615,7 @@
> #define USB_DEVICE_ID_LENOVO_CUSBKBD 0x6047
> #define USB_DEVICE_ID_LENOVO_CBTKBD 0x6048
> #define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067
> +#define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
>
> #define USB_VENDOR_ID_LG 0x1fd2
> #define USB_DEVICE_ID_LG_MULTITOUCH 0x0064
> --
> 1.9.1
next prev parent reply other threads:[~2016-09-12 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 10:45 [PATCH 2/4] HID: add device id for Lenovo X1 Tablet Cover Dennis Wassenberg
2016-09-12 15:53 ` Benjamin Tissoires [this message]
2016-09-14 6:33 ` Dennis Wassenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912155335.GE25951@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=aduggan@synaptics.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=dennis.wassenberg@secunet.com \
--cc=hui.wang@canonical.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=perex@perex.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).