* [PATCH 2/4] HID: add device id for Lenovo X1 Tablet Cover
@ 2016-09-12 10:45 Dennis Wassenberg
2016-09-12 15:53 ` Benjamin Tissoires
0 siblings, 1 reply; 3+ messages in thread
From: Dennis Wassenberg @ 2016-09-12 10:45 UTC (permalink / raw)
To: linux-input, linux-sound, alsa-devel, tiwai, lukas,
Benjamin Tissoires, Andrew Duggan, perex, david.henningsson,
vinod.koul, hui.wang, rafael.j.wysocki, jikos
Add device id for Lenovo X1 Tablet Cover
Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 6add0b6..ba6a200 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2111,6 +2111,7 @@ void hid_disconnect(struct hid_device *hdev)
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE2) },
{ HID_USB_DEVICE(USB_VENDOR_ID_RAZER, USB_DEVICE_ID_RAZER_BLADE_14) },
{ HID_USB_DEVICE(USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM6533) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X1_COVER) },
{ }
};
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 3466f0d..1f08fb5 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -615,6 +615,7 @@
#define USB_DEVICE_ID_LENOVO_CUSBKBD 0x6047
#define USB_DEVICE_ID_LENOVO_CBTKBD 0x6048
#define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067
+#define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
#define USB_VENDOR_ID_LG 0x1fd2
#define USB_DEVICE_ID_LG_MULTITOUCH 0x0064
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/4] HID: add device id for Lenovo X1 Tablet Cover
2016-09-12 10:45 [PATCH 2/4] HID: add device id for Lenovo X1 Tablet Cover Dennis Wassenberg
@ 2016-09-12 15:53 ` Benjamin Tissoires
2016-09-14 6:33 ` Dennis Wassenberg
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Tissoires @ 2016-09-12 15:53 UTC (permalink / raw)
To: Dennis Wassenberg
Cc: linux-input, linux-sound, alsa-devel, tiwai, lukas, Andrew Duggan,
perex, david.henningsson, vinod.koul, hui.wang, rafael.j.wysocki,
jikos
On Sep 12 2016 or thereabouts, Dennis Wassenberg wrote:
> Add device id for Lenovo X1 Tablet Cover
>
> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
> ---
quick comment:
this patch should be squashed with the next one where you add support of
this device to the hid-lenovo module.
Cheers,
Benjamin
> drivers/hid/hid-core.c | 1 +
> drivers/hid/hid-ids.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 6add0b6..ba6a200 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2111,6 +2111,7 @@ void hid_disconnect(struct hid_device *hdev)
> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE2) },
> { HID_USB_DEVICE(USB_VENDOR_ID_RAZER, USB_DEVICE_ID_RAZER_BLADE_14) },
> { HID_USB_DEVICE(USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM6533) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X1_COVER) },
> { }
> };
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 3466f0d..1f08fb5 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -615,6 +615,7 @@
> #define USB_DEVICE_ID_LENOVO_CUSBKBD 0x6047
> #define USB_DEVICE_ID_LENOVO_CBTKBD 0x6048
> #define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067
> +#define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
>
> #define USB_VENDOR_ID_LG 0x1fd2
> #define USB_DEVICE_ID_LG_MULTITOUCH 0x0064
> --
> 1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/4] HID: add device id for Lenovo X1 Tablet Cover
2016-09-12 15:53 ` Benjamin Tissoires
@ 2016-09-14 6:33 ` Dennis Wassenberg
0 siblings, 0 replies; 3+ messages in thread
From: Dennis Wassenberg @ 2016-09-14 6:33 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: linux-input, linux-sound, alsa-devel, tiwai, lukas, Andrew Duggan,
perex, david.henningsson, vinod.koul, hui.wang, rafael.j.wysocki,
jikos
Hi Benjamin,
ok, I will do so.
I will prepare a v2 of "[PATCH 3/4] hid-lenovo: Add support for X1
Tablet special keys and, LED control" which is affected by this change.
Thank you & best regards,
Dennis
On 12.09.2016 17:53, Benjamin Tissoires wrote:
> On Sep 12 2016 or thereabouts, Dennis Wassenberg wrote:
>> Add device id for Lenovo X1 Tablet Cover
>>
>> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
>> ---
>
> quick comment:
>
> this patch should be squashed with the next one where you add support of
> this device to the hid-lenovo module.
>
> Cheers,
> Benjamin
>
>> drivers/hid/hid-core.c | 1 +
>> drivers/hid/hid-ids.h | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> index 6add0b6..ba6a200 100644
>> --- a/drivers/hid/hid-core.c
>> +++ b/drivers/hid/hid-core.c
>> @@ -2111,6 +2111,7 @@ void hid_disconnect(struct hid_device *hdev)
>> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE2) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_RAZER, USB_DEVICE_ID_RAZER_BLADE_14) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM6533) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X1_COVER) },
>> { }
>> };
>>
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index 3466f0d..1f08fb5 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -615,6 +615,7 @@
>> #define USB_DEVICE_ID_LENOVO_CUSBKBD 0x6047
>> #define USB_DEVICE_ID_LENOVO_CBTKBD 0x6048
>> #define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067
>> +#define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
>>
>> #define USB_VENDOR_ID_LG 0x1fd2
>> #define USB_DEVICE_ID_LG_MULTITOUCH 0x0064
>> --
>> 1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-14 6:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 10:45 [PATCH 2/4] HID: add device id for Lenovo X1 Tablet Cover Dennis Wassenberg
2016-09-12 15:53 ` Benjamin Tissoires
2016-09-14 6:33 ` Dennis Wassenberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).