From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Nikolai Kondrashov <spbnick@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH 6/9] HID: uclogic: Add support for several more tablets
Date: Wed, 14 Sep 2016 12:15:31 +0200 [thread overview]
Message-ID: <20160914101531.GJ25951@mail.corp.redhat.com> (raw)
In-Reply-To: <20160913140843.25567-7-spbnick@gmail.com>
On Sep 13 2016 or thereabouts, Nikolai Kondrashov wrote:
> Add more product IDs to hid-uclogic.c driver to support several more
> tablet models, including:
>
> UC-Logic DrawImage G3
> aka Ugee G3
> UC-Logic SP1001
> aka Ugee SP1001
> aka Yiynova UC-Logic SP-1001
> Ugee 1000L
> Ugee M708
> Yiynova DP10U
> aka Yiynova DP10U+
> Yiynova MSP19U
> Yiynova MSP19U+
> Yiynova MVP10U
> aka Yiynova MVP10U IPS
> Yiynova MVP10UHD+IPS
> Yiynova MVP22U+
>
> Signed-off-by: Nikolai Kondrashov <spbnick@gmail.com>
> ---
> drivers/hid/hid-ids.h | 4 ++++
> drivers/hid/hid-uclogic.c | 8 ++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5963cf1..6ef9dbf 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -996,6 +996,10 @@
> #define USB_DEVICE_ID_UCLOGIC_TABLET_WP1062 0x0064
> #define USB_DEVICE_ID_UCLOGIC_WIRELESS_TABLET_TWHL850 0x0522
> #define USB_DEVICE_ID_UCLOGIC_TABLET_TWHA60 0x0781
> +#define USB_DEVICE_ID_UCLOGIC_DRAWIMAGE_G3 0x3031
> +#define USB_DEVICE_ID_UGEE_TABLET_81 0x0081
> +#define USB_DEVICE_ID_UGEE_TABLET_45 0x0045
> +#define USB_DEVICE_ID_YIYNOVA_TABLET 0x004d
>
> #define USB_VENDOR_ID_UNITEC 0x227d
> #define USB_DEVICE_ID_UNITEC_USB_TOUCH_0709 0x0709
> diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c
> index 73c040d..f4377c4 100644
> --- a/drivers/hid/hid-uclogic.c
> +++ b/drivers/hid/hid-uclogic.c
> @@ -955,6 +955,10 @@ static int uclogic_probe(struct hid_device *hdev,
>
> switch (id->product) {
> case USB_DEVICE_ID_HUION_TABLET:
> + case USB_DEVICE_ID_YIYNOVA_TABLET:
> + case USB_DEVICE_ID_UGEE_TABLET_81:
> + case USB_DEVICE_ID_UCLOGIC_DRAWIMAGE_G3:
> + case USB_DEVICE_ID_UGEE_TABLET_45:
> /* If this is the pen interface */
> if (intf->cur_altsetting->desc.bInterfaceNumber == 0) {
> rc = uclogic_tablet_enable(hdev);
> @@ -1023,6 +1027,10 @@ static const struct hid_device_id uclogic_devices[] = {
> USB_DEVICE_ID_UCLOGIC_TABLET_TWHA60) },
> { HID_USB_DEVICE(USB_VENDOR_ID_HUION, USB_DEVICE_ID_HUION_TABLET) },
> { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_HUION_TABLET) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_YIYNOVA_TABLET) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UGEE_TABLET_81) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UGEE_TABLET_45) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_DRAWIMAGE_G3) },
For this one and 7/9, I think you forgot the hid-core.c changes to not
bind hid-generic on those.
The reset of the series looks good to me:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> { }
> };
> MODULE_DEVICE_TABLE(hid, uclogic_devices);
> --
> 2.9.3
>
next prev parent reply other threads:[~2016-09-14 10:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 14:08 [PATCH] hid: Misc tablet fixes and improvements Nikolai Kondrashov
2016-09-13 14:08 ` [PATCH 1/9] HID: Remove broken links to tablet descriptions Nikolai Kondrashov
2016-09-13 14:08 ` [PATCH 2/9] HID: kye: Rename MousePen i608X v2 macro Nikolai Kondrashov
2016-09-13 14:08 ` [PATCH 3/9] HID: kye: Fix MousePen i608X v2 report descriptor Nikolai Kondrashov
2016-09-13 14:08 ` [PATCH 4/9] HID: uclogic: Remove allocation failure messages Nikolai Kondrashov
2016-09-13 14:08 ` [PATCH 5/9] HID: uclogic: Switch to reporting abstract button events Nikolai Kondrashov
2016-09-13 14:08 ` [PATCH 6/9] HID: uclogic: Add support for several more tablets Nikolai Kondrashov
2016-09-14 10:15 ` Benjamin Tissoires [this message]
2016-09-14 18:38 ` [PATCH v2] hid: Misc tablet fixes and improvements Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 1/9] HID: Remove broken links to tablet descriptions Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 2/9] HID: kye: Rename MousePen i608X v2 macro Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 3/9] HID: kye: Fix MousePen i608X v2 report descriptor Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 4/9] HID: uclogic: Remove allocation failure messages Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 5/9] HID: uclogic: Switch to reporting abstract button events Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 6/9] HID: uclogic: Add support for several more tablets Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 7/9] HID: uclogic: Support UGTizer GP0610 partially Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 8/9] HID: uclogic: Override constant descriptors Nikolai Kondrashov
2016-09-14 18:38 ` [PATCH 9/9] HID: uclogic: Add support for UC-Logic TWHA60 v3 Nikolai Kondrashov
2016-09-15 7:14 ` [PATCH v2] hid: Misc tablet fixes and improvements Benjamin Tissoires
2016-09-15 9:09 ` Nikolai Kondrashov
2016-09-19 12:32 ` Jiri Kosina
2016-09-13 14:08 ` [PATCH 7/9] HID: uclogic: Support UGTizer GP0610 partially Nikolai Kondrashov
2016-09-13 14:08 ` [PATCH 8/9] HID: uclogic: Override constant descriptors Nikolai Kondrashov
2016-09-13 14:08 ` [PATCH 9/9] HID: uclogic: Add support for UC-Logic TWHA60 v3 Nikolai Kondrashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914101531.GJ25951@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=spbnick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).