From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH resend 2/5] input: touchscreen: Add LED trigger support to the softbutton code Date: Tue, 20 Sep 2016 09:40:23 -0500 Message-ID: <20160920144023.GA31922@rob-hp-laptop> References: <20160911184408.11657-1-hdegoede@redhat.com> <20160911184408.11657-3-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160911184408.11657-3-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hans de Goede Cc: Dmitry Torokhov , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree List-Id: linux-input@vger.kernel.org On Sun, Sep 11, 2016 at 08:44:05PM +0200, Hans de Goede wrote: > In some hardware there are 1 or more LEDs behind the touchscreen > softbuttons, which are intended to provide visual feedback to the > user that the softbutton has been pressed, this commit adds support > for this. > > Signed-off-by: Hans de Goede > --- > .../bindings/input/touchscreen/softbuttons.txt | 4 ++ > drivers/input/touchscreen/softbuttons.c | 49 +++++++++++++++++++++- > 2 files changed, 52 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/softbuttons.txt b/Documentation/devicetree/bindings/input/touchscreen/softbuttons.txt > index 3eb6f4c..b425b95 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/softbuttons.txt > +++ b/Documentation/devicetree/bindings/input/touchscreen/softbuttons.txt > @@ -17,6 +17,10 @@ Required subnode-properties: > - softbutton-min-y : Y start of the area the softbutton area covers > - softbutton-max-y : Y end of the area the softbutton area covers > > +Optional subnode-properties: > +- linux,led-trigger : String for a LED trigger for providing visual > + feedback that the softbutton has been pressed This should just be a phandle to the LED if you want to describe the link. Or standardize the trigger naming (in the kernel) for buttons and just use the existing 'linux,default-trigger' in the LED node. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html