From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Frank Li <Frank.Li@nxp.com>, Robin Gong <b38343@freescale.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: snvs_pwrkey - drop input_free_device call if input_register_device fails
Date: Fri, 23 Sep 2016 15:01:20 -0700 [thread overview]
Message-ID: <20160923220120.GD25499@dtor-ws> (raw)
In-Reply-To: <1474249756-30843-1-git-send-email-axel.lin@ingics.com>
On Mon, Sep 19, 2016 at 09:49:16AM +0800, Axel Lin wrote:
> Current code uses devm_input_allocate_device() so don't explicitly call
> input_free_device if input_register_device fails.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied, thank you.
> ---
> drivers/input/keyboard/snvs_pwrkey.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c
> index 24a9f59..7544888 100644
> --- a/drivers/input/keyboard/snvs_pwrkey.c
> +++ b/drivers/input/keyboard/snvs_pwrkey.c
> @@ -168,7 +168,6 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
> error = input_register_device(input);
> if (error < 0) {
> dev_err(&pdev->dev, "failed to register input device\n");
> - input_free_device(input);
> return error;
> }
>
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2016-09-23 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 1:49 [PATCH] Input: snvs_pwrkey - drop input_free_device call if input_register_device fails Axel Lin
2016-09-23 22:01 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923220120.GD25499@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=axel.lin@ingics.com \
--cc=b38343@freescale.com \
--cc=linux-input@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).