From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"
Date: Sat, 24 Sep 2016 09:41:08 -0700 [thread overview]
Message-ID: <20160924164108.GB40187@dtor-ws> (raw)
In-Reply-To: <3345f7c1-b823-a819-aabf-5b4990068075@users.sourceforge.net>
On Sat, Sep 24, 2016 at 03:48:54PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 24 Sep 2016 14:30:44 +0200
>
> Add a definition for the macro "pr_fmt" so that its information can be used
> for consistent message output.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/input/joystick/joydump.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/joystick/joydump.c b/drivers/input/joystick/joydump.c
> index f9f6cbe..a38f10e 100644
> --- a/drivers/input/joystick/joydump.c
> +++ b/drivers/input/joystick/joydump.c
> @@ -27,6 +27,8 @@
> * Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
Why did you split it off from the patch where you attempt to use it?
What good does this change do on its own?
> #include <linux/module.h>
> #include <linux/gameport.h>
> #include <linux/kernel.h>
> --
> 2.10.0
>
--
Dmitry
next prev parent reply other threads:[~2016-09-24 16:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 13:45 [PATCH 0/4] Input-gameport: Fine-tuning for joydump_connect() SF Markus Elfring
2016-09-24 13:46 ` [PATCH 1/4] Input-gameport: Use kmalloc_array() in joydump_connect() SF Markus Elfring
2016-09-24 16:42 ` Dmitry Torokhov
2016-09-24 17:04 ` SF Markus Elfring
2016-09-24 13:47 ` [PATCH 2/4] Input-gameport: Delete an error message for a failed memory allocation SF Markus Elfring
2016-09-24 13:48 ` [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump" SF Markus Elfring
2016-09-24 16:41 ` Dmitry Torokhov [this message]
2016-09-24 16:55 ` SF Markus Elfring
2016-09-24 17:03 ` Joe Perches
2016-09-24 17:45 ` SF Markus Elfring
2016-09-24 18:01 ` Joe Perches
2016-09-24 18:45 ` SF Markus Elfring
2016-09-24 13:50 ` [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() SF Markus Elfring
2016-09-24 16:13 ` Joe Perches
2016-09-24 16:32 ` SF Markus Elfring
2016-09-24 16:39 ` Dmitry Torokhov
2016-09-24 17:20 ` SF Markus Elfring
2016-09-24 16:47 ` [PATCH 4/4] " Joe Perches
2016-09-24 19:50 ` SF Markus Elfring
2016-09-24 16:41 ` [PATCH 4/4] " SF Markus Elfring
2016-09-25 7:15 ` [PATCH v2 3/3] " SF Markus Elfring
2016-09-25 7:31 ` Joe Perches
2016-09-25 7:45 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160924164108.GB40187@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).