* [PATCH] HID: add missing \n to end of dev_warn messages
@ 2016-09-27 18:58 Colin King
2016-09-28 18:39 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-09-27 18:58 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trival fix, dev_warn messages are missing a \n, so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
include/linux/hid.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 75b66ec..b2ec827 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -837,7 +837,7 @@ __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
*/
static inline void hid_device_io_start(struct hid_device *hid) {
if (hid->io_started) {
- dev_warn(&hid->dev, "io already started");
+ dev_warn(&hid->dev, "io already started\n");
return;
}
hid->io_started = true;
@@ -857,7 +857,7 @@ static inline void hid_device_io_start(struct hid_device *hid) {
*/
static inline void hid_device_io_stop(struct hid_device *hid) {
if (!hid->io_started) {
- dev_warn(&hid->dev, "io already stopped");
+ dev_warn(&hid->dev, "io already stopped\n");
return;
}
hid->io_started = false;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: add missing \n to end of dev_warn messages
2016-09-27 18:58 [PATCH] HID: add missing \n to end of dev_warn messages Colin King
@ 2016-09-28 18:39 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2016-09-28 18:39 UTC (permalink / raw)
To: Colin King; +Cc: Jiri Kosina, linux-input, linux-kernel
On Sep 27 2016 or thereabouts, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_warn messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> include/linux/hid.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 75b66ec..b2ec827 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -837,7 +837,7 @@ __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
> */
> static inline void hid_device_io_start(struct hid_device *hid) {
> if (hid->io_started) {
> - dev_warn(&hid->dev, "io already started");
> + dev_warn(&hid->dev, "io already started\n");
> return;
> }
> hid->io_started = true;
> @@ -857,7 +857,7 @@ static inline void hid_device_io_start(struct hid_device *hid) {
> */
> static inline void hid_device_io_stop(struct hid_device *hid) {
> if (!hid->io_started) {
> - dev_warn(&hid->dev, "io already stopped");
> + dev_warn(&hid->dev, "io already stopped\n");
> return;
> }
> hid->io_started = false;
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-28 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-27 18:58 [PATCH] HID: add missing \n to end of dev_warn messages Colin King
2016-09-28 18:39 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).