From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: Jiri Kosina <jikos@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: add missing \n to end of dev_warn messages
Date: Wed, 28 Sep 2016 20:39:54 +0200 [thread overview]
Message-ID: <20160928183954.GJ19261@mail.corp.redhat.com> (raw)
In-Reply-To: <20160927185844.14659-1-colin.king@canonical.com>
On Sep 27 2016 or thereabouts, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_warn messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> include/linux/hid.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 75b66ec..b2ec827 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -837,7 +837,7 @@ __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
> */
> static inline void hid_device_io_start(struct hid_device *hid) {
> if (hid->io_started) {
> - dev_warn(&hid->dev, "io already started");
> + dev_warn(&hid->dev, "io already started\n");
> return;
> }
> hid->io_started = true;
> @@ -857,7 +857,7 @@ static inline void hid_device_io_start(struct hid_device *hid) {
> */
> static inline void hid_device_io_stop(struct hid_device *hid) {
> if (!hid->io_started) {
> - dev_warn(&hid->dev, "io already stopped");
> + dev_warn(&hid->dev, "io already stopped\n");
> return;
> }
> hid->io_started = false;
> --
> 2.9.3
>
prev parent reply other threads:[~2016-09-28 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 18:58 [PATCH] HID: add missing \n to end of dev_warn messages Colin King
2016-09-28 18:39 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928183954.GJ19261@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=colin.king@canonical.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).