* [PATCH] HID: sony: Update device ids v2
@ 2016-10-06 18:51 Roderick Colenbrander
2016-10-07 15:49 ` Benjamin Tissoires
0 siblings, 1 reply; 3+ messages in thread
From: Roderick Colenbrander @ 2016-10-06 18:51 UTC (permalink / raw)
To: linux-input
Cc: Benjamin Tissoires, Jiri Kosina, Tim Bird, Roderick Colenbrander
From: Roderick Colenbrander <roderick.colenbrander@sony.com>
Support additional DS4 model.
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
---
drivers/hid/hid-core.c | 2 ++
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-sony.c | 4 ++++
3 files changed, 7 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 2b89c70..5ed2f57 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2059,6 +2059,8 @@ static const struct hid_device_id hid_have_special_driver[] = {
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS3_CONTROLLER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER) },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER_2) },
+ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER_2) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_VAIO_VGX_MOUSE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_VAIO_VGP_MOUSE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SINO_LITE, USB_DEVICE_ID_SINO_LITE_CONTROLLER) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index cd59c79..27f82cc 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -899,6 +899,7 @@
#define USB_DEVICE_ID_SONY_PS3_BDREMOTE 0x0306
#define USB_DEVICE_ID_SONY_PS3_CONTROLLER 0x0268
#define USB_DEVICE_ID_SONY_PS4_CONTROLLER 0x05c4
+#define USB_DEVICE_ID_SONY_PS4_CONTROLLER_2 0x09cc
#define USB_DEVICE_ID_SONY_MOTION_CONTROLLER 0x03d5
#define USB_DEVICE_ID_SONY_NAVIGATION_CONTROLLER 0x042f
#define USB_DEVICE_ID_SONY_BUZZ_CONTROLLER 0x0002
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index c9916cc..3acdb68 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -2639,6 +2639,10 @@ static const struct hid_device_id sony_devices[] = {
.driver_data = DUALSHOCK4_CONTROLLER_USB },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER),
.driver_data = DUALSHOCK4_CONTROLLER_BT },
+ { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER_2),
+ .driver_data = DUALSHOCK4_CONTROLLER_USB },
+ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER_2),
+ .driver_data = DUALSHOCK4_CONTROLLER_BT },
/* Nyko Core Controller for PS3 */
{ HID_USB_DEVICE(USB_VENDOR_ID_SINO_LITE, USB_DEVICE_ID_SINO_LITE_CONTROLLER),
.driver_data = SIXAXIS_CONTROLLER_USB | SINO_LITE_CONTROLLER },
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: sony: Update device ids v2
2016-10-06 18:51 [PATCH] HID: sony: Update device ids v2 Roderick Colenbrander
@ 2016-10-07 15:49 ` Benjamin Tissoires
2016-10-07 18:20 ` Roderick Colenbrander
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Tissoires @ 2016-10-07 15:49 UTC (permalink / raw)
To: Roderick Colenbrander
Cc: linux-input, Jiri Kosina, Tim Bird, Roderick Colenbrander
On Oct 06 2016 or thereabouts, Roderick Colenbrander wrote:
> From: Roderick Colenbrander <roderick.colenbrander@sony.com>
>
> Support additional DS4 model.
>
> Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Roderick, FYI, on a v2, the format for sending the patch is:
[PATCH v2] HID: sony: Update device ids
Given that git will strip out the part in between braces, this way the
title of the commit stays the same :)
Cheers,
Benjamin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: sony: Update device ids v2
2016-10-07 15:49 ` Benjamin Tissoires
@ 2016-10-07 18:20 ` Roderick Colenbrander
0 siblings, 0 replies; 3+ messages in thread
From: Roderick Colenbrander @ 2016-10-07 18:20 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: linux-input, Jiri Kosina, Tim Bird, Roderick Colenbrander
On Fri, Oct 7, 2016 at 8:49 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> On Oct 06 2016 or thereabouts, Roderick Colenbrander wrote:
>> From: Roderick Colenbrander <roderick.colenbrander@sony.com>
>>
>> Support additional DS4 model.
>>
>> Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> Roderick, FYI, on a v2, the format for sending the patch is:
> [PATCH v2] HID: sony: Update device ids
>
> Given that git will strip out the part in between braces, this way the
> title of the commit stays the same :)
>
> Cheers,
> Benjamin
Thanks for pointing out. I will probably send a [PATCH v3] shortly.
I'm leaning towards sending the whole series again, just for clarity,
so no by hand cherry-picking is needed for a merge.
Thanks,
Roderick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-07 18:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-06 18:51 [PATCH] HID: sony: Update device ids v2 Roderick Colenbrander
2016-10-07 15:49 ` Benjamin Tissoires
2016-10-07 18:20 ` Roderick Colenbrander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).