From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: j.anaszewski@samsung.com, linux-leds@vger.kernel.org,
kernel list <linux-kernel@vger.kernel.org>,
jikos@kernel.org, linux-input@vger.kernel.org,
trivial@kernel.org
Subject: Re: [PATCH] hid-led.c: remove unneccessary underscores
Date: Fri, 7 Oct 2016 18:25:56 +0200 [thread overview]
Message-ID: <20161007162556.GH30411@mail.corp.redhat.com> (raw)
In-Reply-To: <20161003094503.GC9131@amd>
On Oct 03 2016 or thereabouts, Pavel Machek wrote:
> On Mon 2016-10-03 10:16:26, Pavel Machek wrote:
> >
> > u8 (and friends) can be used directly in kernel sources (not kernel
> > headers).
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> Zero day bot warned me that this is not quiet correct.
>
> This would be needed on top. Is there interest in fixed patch?
Having both __ and not __ in the same driver would be a little bit
weird. So I'd say we just continue with the existing code. Thanks for
the submission BTW!
Cheers,
Benjamin
>
> diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c
> index cd208ca..be659ca 100644
> --- a/drivers/hid/hid-led.c
> +++ b/drivers/hid/hid-led.c
> @@ -57,8 +57,8 @@ union delcom_packet {
> u8 cmd;
> } rx;
> struct {
> - le16 family_code;
> - le16 security_code;
> + __le16 family_code;
> + __le16 security_code;
> u8 fw_version;
> } fw;
> };
>
>
next prev parent reply other threads:[~2016-10-07 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 8:16 [PATCH] hid-led.c: remove unneccessary underscores Pavel Machek
2016-10-03 9:45 ` Pavel Machek
2016-10-07 16:25 ` Benjamin Tissoires [this message]
2016-10-07 18:46 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007162556.GH30411@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=j.anaszewski@samsung.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).