From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Juergen Borleis <jbe@pengutronix.de>,
linux-input@vger.kernel.org, Markus Pargmann <mpa@pengutronix.de>,
Lee Jones <lee.jones@linaro.org>,
Denis Carikli <denis@eukrea.com>
Subject: Re: [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF
Date: Wed, 26 Oct 2016 16:46:33 -0700 [thread overview]
Message-ID: <20161026234633.GG27930@dtor-ws> (raw)
In-Reply-To: <1476460819-12809-1-git-send-email-javier@osg.samsung.com>
On Fri, Oct 14, 2016 at 01:00:18PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/input/touchscreen/fsl-imx25-tcq.ko | grep alias
>
> After this patch:
>
> $ modinfo drivers/input/touchscreen/fsl-imx25-tcq.ko | grep alias
> alias: of:N*T*Cfsl,imx25-tcqC*
> alias: of:N*T*Cfsl,imx25-tcq
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
> ---
>
> drivers/input/touchscreen/fsl-imx25-tcq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
> index fe9877a6af9e..d50ee490c9cc 100644
> --- a/drivers/input/touchscreen/fsl-imx25-tcq.c
> +++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
> @@ -55,6 +55,7 @@ static const struct of_device_id mx25_tcq_ids[] = {
> { .compatible = "fsl,imx25-tcq", },
> { /* Sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, mx25_tcq_ids);
>
> #define TSC_4WIRE_PRE_INDEX 0
> #define TSC_4WIRE_X_INDEX 1
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2016-10-26 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 16:00 [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF Javier Martinez Canillas
2016-10-14 16:00 ` [PATCH 2/2] Input: da9063 " Javier Martinez Canillas
2016-10-26 23:46 ` Dmitry Torokhov
2016-10-26 23:46 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026234633.GG27930@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=denis@eukrea.com \
--cc=javier@osg.samsung.com \
--cc=jbe@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).