From: "Pali Rohár" <pali.rohar@gmail.com>
To: Paul Donohue <linux-kernel@paulsd.com>
Cc: linux-input@vger.kernel.org, Ben Gamari <ben@smart-cactus.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] Input: ALPS - Fix TrackStick support for SS5 hardware
Date: Sun, 6 Nov 2016 20:57:49 +0100 [thread overview]
Message-ID: <201611062057.52517@pali> (raw)
In-Reply-To: <20161105163047.GE2927@TopQuark.net>
[-- Attachment #1: Type: Text/Plain, Size: 432 bytes --]
On Saturday 05 November 2016 17:30:47 Paul Donohue wrote:
> I was trying to avoid duplicating the detection logic (that is
> already implemented in alps_get_pkt_id_ss4_v2(), but yes, it is
> possible to implement the detection the same way as the other
> devices.
Ah... I see. alps_get_pkt_id_ss4_v2() should returns enum SS4_PACKET_ID
but for some reasons it is unsigned char...
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-11-06 19:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 21:01 [PATCH] Input: ALPS - Fix TrackStick support for SS5 hardware Paul Donohue
2016-11-01 9:35 ` Pali Rohár
2016-11-05 16:30 ` Paul Donohue
2016-11-05 16:44 ` [PATCH v2] " Paul Donohue
2016-11-06 19:59 ` Pali Rohár
2016-11-08 14:24 ` Paul Donohue
2016-11-06 19:57 ` Pali Rohár [this message]
2016-11-08 14:54 ` [PATCH v3 1/3] " Paul Donohue
2016-11-08 14:59 ` [PATCH v3 2/3] " Paul Donohue
2016-11-08 15:06 ` Paul Donohue
2016-11-08 15:14 ` [PATCH v4 1/3] " Paul Donohue
2016-11-08 15:16 ` [PATCH v4 2/3] Input: ALPS - Clean up TrackStick handling " Paul Donohue
2016-11-08 15:17 ` [PATCH v4 3/3] Input: ALPS - Clean up code " Paul Donohue
2016-11-08 15:46 ` Paul Donohue
2016-11-08 15:49 ` Paul Donohue
2016-11-09 12:14 ` [PATCH v4 2/3] Input: ALPS - Clean up TrackStick handling " Pali Rohár
2016-11-10 14:27 ` Paul Donohue
2016-11-10 15:19 ` Pali Rohár
2016-11-10 16:44 ` [PATCH v5 0/3] Input: ALPS - Bug fix and cleanup " Paul Donohue
2016-11-10 16:44 ` [PATCH v5 1/3] Input: ALPS - Fix TrackStick support " Paul Donohue
2016-11-10 16:44 ` [PATCH v5 2/3] Input: ALPS - Clean up TrackStick handling " Paul Donohue
2016-11-10 16:44 ` [PATCH v5 3/3] Input: ALPS - Clean up code " Paul Donohue
2016-11-11 13:59 ` [PATCH v5 0/3] Input: ALPS - Bug fix and cleanup " Pali Rohár
2016-11-12 0:56 ` Dmitry Torokhov
2016-11-12 1:03 ` Pali Rohár
2016-11-12 1:06 ` Dmitry Torokhov
2016-11-12 12:29 ` Pali Rohár
2016-11-13 6:43 ` Dmitry Torokhov
2016-11-13 10:31 ` Pali Rohár
2016-11-13 15:28 ` Paul Donohue
2016-11-24 14:25 ` [PATCH v6 " Paul Donohue
2016-11-24 14:25 ` [PATCH v6 1/3] Input: ALPS - Fix TrackStick support " Paul Donohue
2016-11-24 14:25 ` [PATCH v6 2/3] Input: ALPS - Clean up TrackStick handling " Paul Donohue
2016-11-24 14:25 ` [PATCH v6 3/3] Input: ALPS - Clean up code " Paul Donohue
2016-11-09 12:12 ` [PATCH v4 1/3] Input: ALPS - Fix TrackStick support " Pali Rohár
2016-11-10 14:17 ` Paul Donohue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201611062057.52517@pali \
--to=pali.rohar@gmail.com \
--cc=ben@smart-cactus.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@paulsd.com \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).