From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Maarten ter Huurne <maarten@treewalker.org>
Subject: Re: [PATCH 1/2] Input: gpio_keys - Also send release events for ABS codes
Date: Tue, 8 Nov 2016 16:09:49 -0800 [thread overview]
Message-ID: <20161109000949.GB8719@dtor-ws> (raw)
In-Reply-To: <56a0750b-c0f6-1fad-c730-11213dd64a97@crapouillou.net>
On Sat, Nov 05, 2016 at 12:58:00PM +0100, Paul Cercueil wrote:
> On 03/11/2016 17:21, Dmitry Torokhov wrote:
> >On Tue, Nov 01, 2016 at 11:25:03AM +0100, Paul Cercueil wrote:
> >>Right now, the gpio-keys driver is mostly used with EV_KEY event types.
> >>However, this driver (and its devicetree bindings) support specifying
> >>a different input type, like EV_ABS, even though this doesn't work in
> >>practice: "key pressed" events are correctly received and treated, but
> >>"key released" are silently ignored.
> >>
> >>With this commit, keys configured as EV_ABS will inject an event with
> >>the value 0 when released.
> >No, this will break setups like this:
> >
> >gpio0 - ABS_X - 0
> >gpio1 - ABS_X - 1
> >gpio2 - ABS_X - 2
> >...
> >gpio7 - ABS_X - 7
> >
> >- something like a slider built on top of gpios.
>
> So what would you suggest for the implementation of a hat / d-pad on
> top of GPIOs?
Maybe we should allow specifying "release" value for ABS GPIOs.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2016-11-09 0:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 10:25 [PATCH 0/2] Make gpio-keys usable as a hat Paul Cercueil
2016-11-01 10:25 ` [PATCH 1/2] Input: gpio_keys - Also send release events for ABS codes Paul Cercueil
2016-11-03 16:21 ` Dmitry Torokhov
2016-11-05 11:58 ` Paul Cercueil
2016-11-09 0:09 ` Dmitry Torokhov [this message]
2016-11-01 10:25 ` [PATCH 2/2] Input: gpio_keys - Set ABS params when using axes Paul Cercueil
2016-11-03 16:24 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109000949.GB8719@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten@treewalker.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).