* [PATCH] HID: wacom: Declare tool ID 0x84a as an Intuos eraser
@ 2016-11-11 23:05 Jason Gerecke
2016-11-14 8:35 ` Benjamin Tissoires
2016-11-15 11:15 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Jason Gerecke @ 2016-11-11 23:05 UTC (permalink / raw)
To: linux-input, Jiri Kosina
Cc: Ping Cheng, Aaron Skomra, Benjamin Tissoires, Jason Gerecke,
Jason Gerecke
The eraser end of the 8K pen available for the MobileStudio Pro has a tool
ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently
recognize this ID, causing it to return BTN_TOOL_PEN rather than
BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro
since, as a HID_GENERIC device, the driver relies on the state of the
HID_DG_INVERT usage instead. It would, however, cause problems if the pen
is used with devices that use the traditional 'wacom_intuos_irq' codepath
instead.
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
---
drivers/hid/wacom_wac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 0723ba8..55857bf 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -645,6 +645,7 @@ static int wacom_intuos_get_tool_type(int tool_id)
break;
case 0x82a: /* Eraser */
+ case 0x84a:
case 0x85a:
case 0x91a:
case 0xd1a:
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: wacom: Declare tool ID 0x84a as an Intuos eraser
2016-11-11 23:05 [PATCH] HID: wacom: Declare tool ID 0x84a as an Intuos eraser Jason Gerecke
@ 2016-11-14 8:35 ` Benjamin Tissoires
2016-11-15 11:15 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2016-11-14 8:35 UTC (permalink / raw)
To: Jason Gerecke
Cc: linux-input, Jiri Kosina, Ping Cheng, Aaron Skomra, Jason Gerecke
On Nov 11 2016 or thereabouts, Jason Gerecke wrote:
> The eraser end of the 8K pen available for the MobileStudio Pro has a tool
> ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently
> recognize this ID, causing it to return BTN_TOOL_PEN rather than
> BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro
> since, as a HID_GENERIC device, the driver relies on the state of the
> HID_DG_INVERT usage instead. It would, however, cause problems if the pen
> is used with devices that use the traditional 'wacom_intuos_irq' codepath
> instead.
>
> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: wacom: Declare tool ID 0x84a as an Intuos eraser
2016-11-11 23:05 [PATCH] HID: wacom: Declare tool ID 0x84a as an Intuos eraser Jason Gerecke
2016-11-14 8:35 ` Benjamin Tissoires
@ 2016-11-15 11:15 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2016-11-15 11:15 UTC (permalink / raw)
To: Jason Gerecke
Cc: linux-input, Ping Cheng, Aaron Skomra, Benjamin Tissoires,
Jason Gerecke
On Fri, 11 Nov 2016, Jason Gerecke wrote:
> The eraser end of the 8K pen available for the MobileStudio Pro has a tool
> ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently
> recognize this ID, causing it to return BTN_TOOL_PEN rather than
> BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro
> since, as a HID_GENERIC device, the driver relies on the state of the
> HID_DG_INVERT usage instead. It would, however, cause problems if the pen
> is used with devices that use the traditional 'wacom_intuos_irq' codepath
> instead.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-15 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-11 23:05 [PATCH] HID: wacom: Declare tool ID 0x84a as an Intuos eraser Jason Gerecke
2016-11-14 8:35 ` Benjamin Tissoires
2016-11-15 11:15 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).