From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v5 0/3] Input: ALPS - Bug fix and cleanup for SS5 hardware Date: Fri, 11 Nov 2016 16:56:21 -0800 Message-ID: <20161112005621.GA20989@dtor-glaptop> References: <20161110151942.GA3969@pali> <1478796286-1924-1-git-send-email-linux-kernel@PaulSD.com> <201611111459.12642@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:34391 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965548AbcKLBLY (ORCPT ); Fri, 11 Nov 2016 20:11:24 -0500 Received: by mail-pg0-f67.google.com with SMTP id e9so2714969pgc.1 for ; Fri, 11 Nov 2016 17:11:24 -0800 (PST) Content-Disposition: inline In-Reply-To: <201611111459.12642@pali> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Paul Donohue , linux-input@vger.kernel.org, Ben Gamari , Michal Hocko On Fri, Nov 11, 2016 at 02:59:09PM +0100, Pali Rohár wrote: > On Thursday 10 November 2016 17:44:43 Paul Donohue wrote: > > This series includes a bug fix and assorted cleanup for the Alps SS5 > > (SS4 v2) code. > > > > Changes in v5: > > * Moved TrackStick decoding logic to alps_process_packet_ss4_v2() to > > make the code more consistent with other protocol versions > > (Suggested by Pali Rohár ) > > > > Changes in v4: > > * Fixed patch formatting issues > > * Correct casting issues in macros added in v3 > > > > Changes in v3: > > * Added additional code cleanup to make the code easier to understand > > (Suggested by Pali Rohár ) > > > > Changes in v2: > > * For consistency with other Alps functions, check packet bytes for > > packet type rather than adding a flag to alps_fields for packet > > type. (Suggested by Pali Rohár ) > > > > Paul Donohue (3): > > Input: ALPS - Fix TrackStick support for SS5 hardware > > Input: ALPS - Clean up TrackStick handling for SS5 hardware > > Input: ALPS - Clean up code for SS5 hardware > > > > drivers/input/mouse/alps.c | 59 > > +++++++++++++++++++++++++--------------------- > > drivers/input/mouse/alps.h | 22 ++++++++++++++++- > > 2 files changed, 53 insertions(+), 28 deletions(-) > > Whole patch series looks fine. > You can add my Reviewed-by: Pali Rohár FYI: I do not see a dingle email from Paul, only your replies. Thanks. -- Dmitry