From: "Pali Rohár" <pali.rohar@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Chris Diamand <chris@diamand.org>,
phonesyfreakies@gmail.com, Michael Shell <list1@michaelshell.org>,
Eric Wong <normalperson@yhbt.net>,
Ondrej Zary <linux@rainbow-software.org>,
Christophe TORDEUX <christophe@tordeux.net>,
Richard Pospesel <pospeselr@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: psmouse - disable automatic probing of BYD touchpads
Date: Sat, 12 Nov 2016 20:39:32 +0100 [thread overview]
Message-ID: <201611122039.33245@pali> (raw)
In-Reply-To: <20161112191545.GA19531@dtor-ws>
[-- Attachment #1: Type: Text/Plain, Size: 1277 bytes --]
On Saturday 12 November 2016 20:15:45 Dmitry Torokhov wrote:
> BYD automatic protocol detection is extremely unreliable and is often
> triggers false positives on regular mice, Sentelic touchpads, and
> other devices. BYD has several documents that have recommended
> detection sequence, but they conflict with each other and, as far as
> I can see, still would not produce unique enough output to reliably
> differentiate BYD from other PS/2 devices.
>
> OEMs sourcing BYD devices also do not do us any favors by not
> supplying any reasonable DMI data and instead leaving turds like "To
> Be Filled By O.E.M." in place of vendor data, or "System Serial
> Number" as serial number.
...
> echo -n "byd" > /sys/bus/serio/devices/serio1/drvctl
I agree, if we cannot detect BYD devices correctly without breaking
other non-BYD devices then detection must be done by user...
So you can add my Reviewed-by: Pali Rohár to this patch.
Anyway, BYD show Linux as supported OS for their devices. It is really
rude from BYD that they show Linux as supported OS, but Linux driver is
reverse-engineered by community and they do not want to cooperate and at
least provide some useful documentation for detection...
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-11-12 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 19:15 [PATCH] Input: psmouse - disable automatic probing of BYD touchpads Dmitry Torokhov
2016-11-12 19:39 ` Pali Rohár [this message]
2016-11-13 7:13 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201611122039.33245@pali \
--to=pali.rohar@gmail.com \
--cc=chris@diamand.org \
--cc=christophe@tordeux.net \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=list1@michaelshell.org \
--cc=normalperson@yhbt.net \
--cc=phonesyfreakies@gmail.com \
--cc=pospeselr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).