From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jason Gerecke <killertofu@gmail.com>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Ping Cheng <pinglinux@gmail.com>, Aaron Skomra <skomra@gmail.com>,
Jason Gerecke <jason.gerecke@wacom.com>
Subject: Re: [PATCH] HID: wacom: Declare tool ID 0x84a as an Intuos eraser
Date: Mon, 14 Nov 2016 09:35:49 +0100 [thread overview]
Message-ID: <20161114083549.GA21746@mail.corp.redhat.com> (raw)
In-Reply-To: <20161111230552.4221-1-killertofu@gmail.com>
On Nov 11 2016 or thereabouts, Jason Gerecke wrote:
> The eraser end of the 8K pen available for the MobileStudio Pro has a tool
> ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently
> recognize this ID, causing it to return BTN_TOOL_PEN rather than
> BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro
> since, as a HID_GENERIC device, the driver relies on the state of the
> HID_DG_INVERT usage instead. It would, however, cause problems if the pen
> is used with devices that use the traditional 'wacom_intuos_irq' codepath
> instead.
>
> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
next prev parent reply other threads:[~2016-11-14 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 23:05 [PATCH] HID: wacom: Declare tool ID 0x84a as an Intuos eraser Jason Gerecke
2016-11-14 8:35 ` Benjamin Tissoires [this message]
2016-11-15 11:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114083549.GA21746@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=jkosina@suse.cz \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
--cc=skomra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).