From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guy Shapiro <guy.shapiro@mobi-wize.com>
Cc: Haibo Chen <haibo.chen@nxp.com>,
linux-input@vger.kernel.org, fabio.estevam@nxp.com
Subject: Re: [PATCH] input: touchscreen: imx6ul_tsc: add mask when set REG_ADC_CFG
Date: Wed, 30 Nov 2016 09:02:38 -0800 [thread overview]
Message-ID: <20161130170238.GA31934@dtor-ws> (raw)
In-Reply-To: <a842b4bd-f8ed-731e-5017-4ec74130506a@mobi-wize.com>
On Tue, Nov 29, 2016 at 02:36:51PM +0200, Guy Shapiro wrote:
> On 28/11/2016 10:42, Haibo Chen wrote:
> >Add mask of each function bits of REG_ADC_CFG, and clear these
> >function bits first, otherwise use '|=' operation may get the
> >wrong setting which depends on the original value of REG_ADC_CFG.
> >
> >Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> >---
> > drivers/input/touchscreen/imx6ul_tsc.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> Reviewed-by: Guy Shapiro <guy.shapiro@mobi-wize.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2016-11-30 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 8:42 [PATCH] input: touchscreen: imx6ul_tsc: add mask when set REG_ADC_CFG Haibo Chen
2016-11-29 12:36 ` Guy Shapiro
2016-11-30 17:02 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130170238.GA31934@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=guy.shapiro@mobi-wize.com \
--cc=haibo.chen@nxp.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).