* [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP
@ 2016-12-09 23:55 Marcos Paulo de Souza
2016-12-10 2:00 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Marcos Paulo de Souza @ 2016-12-09 23:55 UTC (permalink / raw)
Cc: Marcos Paulo de Souza, Dmitry Torokhov, Patrick Scheuring,
Aurélien Francillon, linux-input, linux-kernel
As this define check if huge, this makes easier to read the code.
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
While reviewing patches from Dmitry about presence of 8042, it makes it
much easier to understand the ifdefs...
drivers/input/serio/i8042-x86ia64io.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index 073246c..ddd3132 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -1131,10 +1131,10 @@ static int __init i8042_pnp_init(void)
return 0;
}
-#else
+#else /* !CONFIG_PNP */
static inline int i8042_pnp_init(void) { return 0; }
static inline void i8042_pnp_exit(void) { }
-#endif
+#endif /* CONFIG_PNP */
static int __init i8042_platform_init(void)
{
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP
2016-12-09 23:55 [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP Marcos Paulo de Souza
@ 2016-12-10 2:00 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2016-12-10 2:00 UTC (permalink / raw)
To: Marcos Paulo de Souza
Cc: Patrick Scheuring, Aurélien Francillon, linux-input,
linux-kernel
On Fri, Dec 09, 2016 at 09:55:09PM -0200, Marcos Paulo de Souza wrote:
> As this define check if huge, this makes easier to read the code.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Applied, thank you.
> ---
> While reviewing patches from Dmitry about presence of 8042, it makes it
> much easier to understand the ifdefs...
>
> drivers/input/serio/i8042-x86ia64io.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 073246c..ddd3132 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -1131,10 +1131,10 @@ static int __init i8042_pnp_init(void)
> return 0;
> }
>
> -#else
> +#else /* !CONFIG_PNP */
> static inline int i8042_pnp_init(void) { return 0; }
> static inline void i8042_pnp_exit(void) { }
> -#endif
> +#endif /* CONFIG_PNP */
>
> static int __init i8042_platform_init(void)
> {
> --
> 2.9.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-10 2:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-09 23:55 [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP Marcos Paulo de Souza
2016-12-10 2:00 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).