linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-input@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH v1 1/1] Input: adxl34x - Make it enumerable in ACPI environment
Date: Mon, 2 Jan 2017 22:35:01 -0800	[thread overview]
Message-ID: <20170103063501.GB5743@dtor-ws> (raw)
In-Reply-To: <20170102120624.178283-1-andriy.shevchenko@linux.intel.com>

On Mon, Jan 02, 2017 at 02:06:23PM +0200, Andy Shevchenko wrote:
> The ACPI-enabled platform may contain _DSD method to enable this driver using
> compatible string.
> 
> Remove OF specifics to re-use existing code on ACPI-enabled platforms.

Is there an x86 box that uses this device?

Thanks.

> 
> Suggested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/input/misc/adxl34x-i2c.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/input/misc/adxl34x-i2c.c b/drivers/input/misc/adxl34x-i2c.c
> index a8b0a2eec344..7fed92fb8cc1 100644
> --- a/drivers/input/misc/adxl34x-i2c.c
> +++ b/drivers/input/misc/adxl34x-i2c.c
> @@ -136,7 +136,6 @@ static const struct i2c_device_id adxl34x_id[] = {
>  
>  MODULE_DEVICE_TABLE(i2c, adxl34x_id);
>  
> -#ifdef CONFIG_OF
>  static const struct of_device_id adxl34x_of_id[] = {
>  	/*
>  	 * The ADXL346 is backward-compatible with the ADXL345. Differences are
> @@ -153,13 +152,12 @@ static const struct of_device_id adxl34x_of_id[] = {
>  };
>  
>  MODULE_DEVICE_TABLE(of, adxl34x_of_id);
> -#endif
>  
>  static struct i2c_driver adxl34x_driver = {
>  	.driver = {
>  		.name = "adxl34x",
>  		.pm = &adxl34x_i2c_pm,
> -		.of_match_table = of_match_ptr(adxl34x_of_id),
> +		.of_match_table = adxl34x_of_id,
>  	},
>  	.probe    = adxl34x_i2c_probe,
>  	.remove   = adxl34x_i2c_remove,
> -- 
> 2.11.0
> 

-- 
Dmitry

  reply	other threads:[~2017-01-03  6:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 12:06 [PATCH v1 1/1] Input: adxl34x - Make it enumerable in ACPI environment Andy Shevchenko
2017-01-03  6:35 ` Dmitry Torokhov [this message]
2017-01-03 10:49   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170103063501.GB5743@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-input@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).