From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node Date: Tue, 3 Jan 2017 18:49:55 +0200 Message-ID: <20170103164955.2oqyd2du2dom7wym@kozik-lap> References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jaechul Lee Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Andi Shyti , Chanwoo Choi , Catalin Marinas , Dmitry Torokhov , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Javier Martinez Canillas , Kukjin Kim , Krzysztof Kozlowski , linux-input@vger.kernel.org, galaxyra@gmail.com, beomho.seo@samsung.com, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org On Tue, Jan 03, 2017 at 04:57:17PM +0900, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Jaechul Lee > Signed-off-by: Beomho Seo > Signed-off-by: Andi Shyti The order of sign-offs should follow the order of "who touched it". I assume that the real order was like this: 1. Initially create by Beomho, 2. Adjustments by Andi, 3. Final adjustments and sending by you. If that is correct then the order should be 1->2->3. Beside of that, patch looks good. Best regards, Krzysztof