From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for TM2 Date: Tue, 3 Jan 2017 18:59:20 +0200 Message-ID: <20170103165920.4tmpr3skgzb2dfah@kozik-lap> References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-3-git-send-email-jcsing.lee@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1483430237-26823-3-git-send-email-jcsing.lee@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jaechul Lee Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Andi Shyti , Chanwoo Choi , Catalin Marinas , Dmitry Torokhov , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Javier Martinez Canillas , Kukjin Kim , Krzysztof Kozlowski , linux-input@vger.kernel.org, galaxyra@gmail.com, beomho.seo@samsung.com, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org On Tue, Jan 03, 2017 at 04:57:15PM +0900, Jaechul Lee wrote: > This patch adds support for the TM2 touch key and led > functionlity. > > The driver interfaces with userspace through an input device and > reports KEY_PHONE and KEY_BACK event types. LED brightness can be > controlled by "/sys/class/leds/tm2-touchkey/brightness". > > Signed-off-by: Jaechul Lee > Signed-off-by: Beomho Seo > --- > drivers/input/keyboard/Kconfig | 11 ++ > drivers/input/keyboard/Makefile | 1 + > drivers/input/keyboard/tm2-touchkey.c | 326 ++++++++++++++++++++++++++++++++++ > 3 files changed, 338 insertions(+) > create mode 100644 drivers/input/keyboard/tm2-touchkey.c > > diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig > index cbd75cf..72c0ba1 100644 > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > @@ -666,6 +666,17 @@ config KEYBOARD_TC3589X > To compile this driver as a module, choose M here: the > module will be called tc3589x-keypad. > > +config KEYBOARD_TM2_TOUCHKEY > + tristate "tm2-touchkey support" > + depends on I2C > + help > + Say Y here to enable the tm2-touchkey. The ending full stop is not needed. > + touchkey driver for tm2. This driver can enable > + the interrupt and make input events and control led brightness. This sentence needs improvements. How about just: "Beside input device, this driver provides also brightness control for LEDs on touch keys." Best regards, Krzysztof