From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paul Donohue <linux-kernel@PaulSD.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: ALPS - fix TrackStick Y axis handling for SS5 hardware
Date: Tue, 3 Jan 2017 10:41:56 -0800 [thread overview]
Message-ID: <20170103184156.GB16032@dtor-ws> (raw)
In-Reply-To: <1483447529-13565-1-git-send-email-linux-kernel@PaulSD.com>
On Tue, Jan 03, 2017 at 07:45:29AM -0500, Paul Donohue wrote:
> A minus character was lost in commit 23fce365, causing the Y axis to be
> inverted for SS5 TrackStick events. (Pushing the TrackStick up caused
> the pointer to move down, and vice versa.) Restore the lost minus.
>
> Signed-off-by: Paul Donohue <linux-kernel@PaulSD.com>
Applied, thank you.
> ---
> drivers/input/mouse/alps.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h
> index cde6f4b..6d279aa 100644
> --- a/drivers/input/mouse/alps.h
> +++ b/drivers/input/mouse/alps.h
> @@ -114,7 +114,7 @@ enum SS4_PACKET_ID {
> (_b[1] & 0x7F) \
> )
>
> -#define SS4_TS_Y_V2(_b) (s8)( \
> +#define SS4_TS_Y_V2(_b) -(s8)( \
> ((_b[3] & 0x01) << 7) | \
> (_b[2] & 0x7F) \
> )
> --
> 2.9.3
>
--
Dmitry
prev parent reply other threads:[~2017-01-03 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 12:45 [PATCH] Input: ALPS - fix TrackStick Y axis handling for SS5 hardware Paul Donohue
2017-01-03 18:41 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103184156.GB16032@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@PaulSD.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).