* [PATCH] Input: ALPS - fix TrackStick Y axis handling for SS5 hardware
@ 2017-01-03 12:45 Paul Donohue
2017-01-03 18:41 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Paul Donohue @ 2017-01-03 12:45 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Paul Donohue
A minus character was lost in commit 23fce365, causing the Y axis to be
inverted for SS5 TrackStick events. (Pushing the TrackStick up caused
the pointer to move down, and vice versa.) Restore the lost minus.
Signed-off-by: Paul Donohue <linux-kernel@PaulSD.com>
---
drivers/input/mouse/alps.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h
index cde6f4b..6d279aa 100644
--- a/drivers/input/mouse/alps.h
+++ b/drivers/input/mouse/alps.h
@@ -114,7 +114,7 @@ enum SS4_PACKET_ID {
(_b[1] & 0x7F) \
)
-#define SS4_TS_Y_V2(_b) (s8)( \
+#define SS4_TS_Y_V2(_b) -(s8)( \
((_b[3] & 0x01) << 7) | \
(_b[2] & 0x7F) \
)
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: ALPS - fix TrackStick Y axis handling for SS5 hardware
2017-01-03 12:45 [PATCH] Input: ALPS - fix TrackStick Y axis handling for SS5 hardware Paul Donohue
@ 2017-01-03 18:41 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-01-03 18:41 UTC (permalink / raw)
To: Paul Donohue; +Cc: linux-input
On Tue, Jan 03, 2017 at 07:45:29AM -0500, Paul Donohue wrote:
> A minus character was lost in commit 23fce365, causing the Y axis to be
> inverted for SS5 TrackStick events. (Pushing the TrackStick up caused
> the pointer to move down, and vice versa.) Restore the lost minus.
>
> Signed-off-by: Paul Donohue <linux-kernel@PaulSD.com>
Applied, thank you.
> ---
> drivers/input/mouse/alps.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h
> index cde6f4b..6d279aa 100644
> --- a/drivers/input/mouse/alps.h
> +++ b/drivers/input/mouse/alps.h
> @@ -114,7 +114,7 @@ enum SS4_PACKET_ID {
> (_b[1] & 0x7F) \
> )
>
> -#define SS4_TS_Y_V2(_b) (s8)( \
> +#define SS4_TS_Y_V2(_b) -(s8)( \
> ((_b[3] & 0x01) << 7) | \
> (_b[2] & 0x7F) \
> )
> --
> 2.9.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-03 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-03 12:45 [PATCH] Input: ALPS - fix TrackStick Y axis handling for SS5 hardware Paul Donohue
2017-01-03 18:41 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).