* Remove DRIVER_LICENSE? @ 2017-01-04 17:58 Grant Grundler 2017-01-04 18:12 ` Dmitry Torokhov 0 siblings, 1 reply; 7+ messages in thread From: Grant Grundler @ 2017-01-04 17:58 UTC (permalink / raw) To: linux-input; +Cc: Dmitry Torokhov I'm researching MODULE_LICENSE uses/declarations and AFAICT DRIVER_LICENSE is only obfuscating the programatically declared license. e.g.: drivers/hid/hid-core.c:#define DRIVER_LICENSE "GPL" drivers/hid/hid-core.c:MODULE_LICENSE(DRIVER_LICENSE); drivers/hid/usbhid/usbmouse.c:#define DRIVER_LICENSE "GPL" drivers/hid/usbhid/usbmouse.c:MODULE_LICENSE(DRIVER_LICENSE); drivers/hid/usbhid/usbkbd.c:#define DRIVER_LICENSE "GPL" drivers/hid/usbhid/usbkbd.c:MODULE_LICENSE(DRIVER_LICENSE); drivers/hid/wacom.h:#define DRIVER_LICENSE "GPL" drivers/hid/wacom_sys.c:MODULE_LICENSE(DRIVER_LICENSE); Any objection to removing those uses in drivers/hid? cheers, grant ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Remove DRIVER_LICENSE? 2017-01-04 17:58 Remove DRIVER_LICENSE? Grant Grundler @ 2017-01-04 18:12 ` Dmitry Torokhov 2017-01-04 18:14 ` Dmitry Torokhov 0 siblings, 1 reply; 7+ messages in thread From: Dmitry Torokhov @ 2017-01-04 18:12 UTC (permalink / raw) To: Grant Grundler; +Cc: linux-input, Dmitry Torokhov On Wed, Jan 4, 2017 at 9:58 AM, Grant Grundler <grundler@google.com> wrote: > I'm researching MODULE_LICENSE uses/declarations and AFAICT > DRIVER_LICENSE is only obfuscating the programatically declared > license. e.g.: > > drivers/hid/hid-core.c:#define DRIVER_LICENSE "GPL" > drivers/hid/hid-core.c:MODULE_LICENSE(DRIVER_LICENSE); > drivers/hid/usbhid/usbmouse.c:#define DRIVER_LICENSE "GPL" > drivers/hid/usbhid/usbmouse.c:MODULE_LICENSE(DRIVER_LICENSE); > drivers/hid/usbhid/usbkbd.c:#define DRIVER_LICENSE "GPL" > drivers/hid/usbhid/usbkbd.c:MODULE_LICENSE(DRIVER_LICENSE); > drivers/hid/wacom.h:#define DRIVER_LICENSE "GPL" > drivers/hid/wacom_sys.c:MODULE_LICENSE(DRIVER_LICENSE); > > Any objection to removing those uses in drivers/hid? Sounds good to me. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Remove DRIVER_LICENSE? 2017-01-04 18:12 ` Dmitry Torokhov @ 2017-01-04 18:14 ` Dmitry Torokhov 2017-01-05 9:24 ` Benjamin Tissoires 2017-01-05 10:19 ` Jiri Kosina 0 siblings, 2 replies; 7+ messages in thread From: Dmitry Torokhov @ 2017-01-04 18:14 UTC (permalink / raw) To: Grant Grundler; +Cc: linux-input, Jiri Kosina, Benjamin Tissoires, Ping Cheng [ let's add a few people ] On Wed, Jan 4, 2017 at 10:12 AM, Dmitry Torokhov <dtor@chromium.org> wrote: > On Wed, Jan 4, 2017 at 9:58 AM, Grant Grundler <grundler@google.com> wrote: >> I'm researching MODULE_LICENSE uses/declarations and AFAICT >> DRIVER_LICENSE is only obfuscating the programatically declared >> license. e.g.: >> >> drivers/hid/hid-core.c:#define DRIVER_LICENSE "GPL" >> drivers/hid/hid-core.c:MODULE_LICENSE(DRIVER_LICENSE); >> drivers/hid/usbhid/usbmouse.c:#define DRIVER_LICENSE "GPL" >> drivers/hid/usbhid/usbmouse.c:MODULE_LICENSE(DRIVER_LICENSE); >> drivers/hid/usbhid/usbkbd.c:#define DRIVER_LICENSE "GPL" >> drivers/hid/usbhid/usbkbd.c:MODULE_LICENSE(DRIVER_LICENSE); >> drivers/hid/wacom.h:#define DRIVER_LICENSE "GPL" >> drivers/hid/wacom_sys.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> Any objection to removing those uses in drivers/hid? > > Sounds good to me. > > Thanks. > > -- > Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Remove DRIVER_LICENSE? 2017-01-04 18:14 ` Dmitry Torokhov @ 2017-01-05 9:24 ` Benjamin Tissoires 2017-01-05 10:19 ` Jiri Kosina 1 sibling, 0 replies; 7+ messages in thread From: Benjamin Tissoires @ 2017-01-05 9:24 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: Grant Grundler, linux-input, Jiri Kosina, Ping Cheng On Jan 04 2017 or thereabouts, Dmitry Torokhov wrote: > [ let's add a few people ] > > On Wed, Jan 4, 2017 at 10:12 AM, Dmitry Torokhov <dtor@chromium.org> wrote: > > On Wed, Jan 4, 2017 at 9:58 AM, Grant Grundler <grundler@google.com> wrote: > >> I'm researching MODULE_LICENSE uses/declarations and AFAICT > >> DRIVER_LICENSE is only obfuscating the programatically declared > >> license. e.g.: > >> > >> drivers/hid/hid-core.c:#define DRIVER_LICENSE "GPL" > >> drivers/hid/hid-core.c:MODULE_LICENSE(DRIVER_LICENSE); > >> drivers/hid/usbhid/usbmouse.c:#define DRIVER_LICENSE "GPL" > >> drivers/hid/usbhid/usbmouse.c:MODULE_LICENSE(DRIVER_LICENSE); > >> drivers/hid/usbhid/usbkbd.c:#define DRIVER_LICENSE "GPL" > >> drivers/hid/usbhid/usbkbd.c:MODULE_LICENSE(DRIVER_LICENSE); > >> drivers/hid/wacom.h:#define DRIVER_LICENSE "GPL" > >> drivers/hid/wacom_sys.c:MODULE_LICENSE(DRIVER_LICENSE); > >> > >> Any objection to removing those uses in drivers/hid? > > > > Sounds good to me. No objections on my side. Cheers, Benjamin ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Remove DRIVER_LICENSE? 2017-01-04 18:14 ` Dmitry Torokhov 2017-01-05 9:24 ` Benjamin Tissoires @ 2017-01-05 10:19 ` Jiri Kosina 2017-01-05 17:29 ` Grant Grundler 2017-01-05 19:09 ` Grant Grundler 1 sibling, 2 replies; 7+ messages in thread From: Jiri Kosina @ 2017-01-05 10:19 UTC (permalink / raw) To: Dmitry Torokhov Cc: Grant Grundler, linux-input, Benjamin Tissoires, Ping Cheng On Wed, 4 Jan 2017, Dmitry Torokhov wrote: > [ let's add a few people ] > > On Wed, Jan 4, 2017 at 10:12 AM, Dmitry Torokhov <dtor@chromium.org> wrote: > > On Wed, Jan 4, 2017 at 9:58 AM, Grant Grundler <grundler@google.com> wrote: > >> I'm researching MODULE_LICENSE uses/declarations and AFAICT > >> DRIVER_LICENSE is only obfuscating the programatically declared > >> license. e.g.: > >> > >> drivers/hid/hid-core.c:#define DRIVER_LICENSE "GPL" > >> drivers/hid/hid-core.c:MODULE_LICENSE(DRIVER_LICENSE); > >> drivers/hid/usbhid/usbmouse.c:#define DRIVER_LICENSE "GPL" > >> drivers/hid/usbhid/usbmouse.c:MODULE_LICENSE(DRIVER_LICENSE); > >> drivers/hid/usbhid/usbkbd.c:#define DRIVER_LICENSE "GPL" > >> drivers/hid/usbhid/usbkbd.c:MODULE_LICENSE(DRIVER_LICENSE); > >> drivers/hid/wacom.h:#define DRIVER_LICENSE "GPL" > >> drivers/hid/wacom_sys.c:MODULE_LICENSE(DRIVER_LICENSE); > >> > >> Any objection to removing those uses in drivers/hid? Nope, let's do it. Grant, will you send me a patch? -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Remove DRIVER_LICENSE? 2017-01-05 10:19 ` Jiri Kosina @ 2017-01-05 17:29 ` Grant Grundler 2017-01-05 19:09 ` Grant Grundler 1 sibling, 0 replies; 7+ messages in thread From: Grant Grundler @ 2017-01-05 17:29 UTC (permalink / raw) To: Jiri Kosina; +Cc: Dmitry Torokhov, linux-input, Benjamin Tissoires, Ping Cheng On Thu, Jan 5, 2017 at 2:19 AM, Jiri Kosina <jikos@kernel.org> wrote: > On Wed, 4 Jan 2017, Dmitry Torokhov wrote: > >> [ let's add a few people ] >> >> On Wed, Jan 4, 2017 at 10:12 AM, Dmitry Torokhov <dtor@chromium.org> wrote: >> > On Wed, Jan 4, 2017 at 9:58 AM, Grant Grundler <grundler@google.com> wrote: >> >> I'm researching MODULE_LICENSE uses/declarations and AFAICT >> >> DRIVER_LICENSE is only obfuscating the programatically declared >> >> license. e.g.: >> >> >> >> drivers/hid/hid-core.c:#define DRIVER_LICENSE "GPL" >> >> drivers/hid/hid-core.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> drivers/hid/usbhid/usbmouse.c:#define DRIVER_LICENSE "GPL" >> >> drivers/hid/usbhid/usbmouse.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> drivers/hid/usbhid/usbkbd.c:#define DRIVER_LICENSE "GPL" >> >> drivers/hid/usbhid/usbkbd.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> drivers/hid/wacom.h:#define DRIVER_LICENSE "GPL" >> >> drivers/hid/wacom_sys.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> >> >> Any objection to removing those uses in drivers/hid? > > Nope, let's do it. Grant, will you send me a patch? Yes. It's a trivial patch. I'll prep that right now and send once I've at least compiled the kernel with it. cheers, grant ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Remove DRIVER_LICENSE? 2017-01-05 10:19 ` Jiri Kosina 2017-01-05 17:29 ` Grant Grundler @ 2017-01-05 19:09 ` Grant Grundler 1 sibling, 0 replies; 7+ messages in thread From: Grant Grundler @ 2017-01-05 19:09 UTC (permalink / raw) To: Jiri Kosina; +Cc: Dmitry Torokhov, linux-input, Benjamin Tissoires, Ping Cheng On Thu, Jan 5, 2017 at 2:19 AM, Jiri Kosina <jikos@kernel.org> wrote: > On Wed, 4 Jan 2017, Dmitry Torokhov wrote: > >> [ let's add a few people ] >> >> On Wed, Jan 4, 2017 at 10:12 AM, Dmitry Torokhov <dtor@chromium.org> wrote: >> > On Wed, Jan 4, 2017 at 9:58 AM, Grant Grundler <grundler@google.com> wrote: >> >> I'm researching MODULE_LICENSE uses/declarations and AFAICT >> >> DRIVER_LICENSE is only obfuscating the programatically declared >> >> license. e.g.: >> >> >> >> drivers/hid/hid-core.c:#define DRIVER_LICENSE "GPL" >> >> drivers/hid/hid-core.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> drivers/hid/usbhid/usbmouse.c:#define DRIVER_LICENSE "GPL" >> >> drivers/hid/usbhid/usbmouse.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> drivers/hid/usbhid/usbkbd.c:#define DRIVER_LICENSE "GPL" >> >> drivers/hid/usbhid/usbkbd.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> drivers/hid/wacom.h:#define DRIVER_LICENSE "GPL" >> >> drivers/hid/wacom_sys.c:MODULE_LICENSE(DRIVER_LICENSE); >> >> >> >> Any objection to removing those uses in drivers/hid? > > Nope, let's do it. Grant, will you send me a patch? Thanks again Jiri - patch sent with "[PATCH] HID: remove use of DRIVER_LICENSE" subject. cheers, grant > > -- > Jiri Kosina > SUSE Labs > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-05 19:09 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-01-04 17:58 Remove DRIVER_LICENSE? Grant Grundler 2017-01-04 18:12 ` Dmitry Torokhov 2017-01-04 18:14 ` Dmitry Torokhov 2017-01-05 9:24 ` Benjamin Tissoires 2017-01-05 10:19 ` Jiri Kosina 2017-01-05 17:29 ` Grant Grundler 2017-01-05 19:09 ` Grant Grundler
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).