From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 4/4] arm64: dts: exynos: Add tm2 touchkey node Date: Thu, 5 Jan 2017 20:41:40 +0200 Message-ID: <20170105184140.tongd3evzm57qkps@kozik-lap> References: <1483604833-29746-1-git-send-email-jcsing.lee@samsung.com> <1483604833-29746-5-git-send-email-jcsing.lee@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1483604833-29746-5-git-send-email-jcsing.lee@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jaechul Lee Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Andi Shyti , Chanwoo Choi , Catalin Marinas , Dmitry Torokhov , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Javier Martinez Canillas , Kukjin Kim , Krzysztof Kozlowski , linux-input@vger.kernel.org, galaxyra@gmail.com, beomho.seo@samsung.com, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org On Thu, Jan 05, 2017 at 05:27:13PM +0900, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Beomho Seo > Signed-off-by: Jaechul Lee > Signed-off-by: Andi Shyti > Reviewed-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski Although I said the patch looks correct, it was not an explicit Review (and we have a quite serious "Reviewer's statement of oversight") so my tag should not be added. No harm was done, but I prefer clearly and explicitly given tags. Best regards, Krzysztof > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index aa8584a..dad6fb8 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -17,3 +17,16 @@ > model = "Samsung TM2 board"; > compatible = "samsung,tm2", "samsung,exynos5433"; > }; > + > +&hsi2c_9 { > + status = "okay"; > + > + touchkey@20 { > + compatible = "samsung,tm2-touchkey"; > + reg = <0x20>; > + interrupt-parent = <&gpa3>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + vcc-supply = <&ldo32_reg>; > + vdd-supply = <&ldo33_reg>; > + }; > +}; > -- > 2.7.4 >