linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Jaechul Lee <jcsing.lee@samsung.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Andi Shyti <andi@etezian.org>,
	linux-input@vger.kernel.org, Jaechul Lee <galaxyra@gmail.com>,
	Beomho Seo <beomho.seo@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong values foe ldo23 and ldo25
Date: Fri, 6 Jan 2017 14:01:49 +0200	[thread overview]
Message-ID: <20170106120149.n2hak4vokip75pda@kozik-lap> (raw)
In-Reply-To: <20170106114114.19321-2-andi.shyti@samsung.com>

On Fri, Jan 06, 2017 at 08:41:10PM +0900, Andi Shyti wrote:
> From: Chanwoo Choi <cw00.choi@samsung.com>
> 
> This patch fixes wrong values assigned to ldo23 and ldo25 on both TM2 and TM2E.
> 
> Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board")
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts  | 7 ++++---
>  arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 9 ---------
>  2 files changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> index 3b5215c40fcd..e8971f4a5977 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> @@ -504,9 +504,9 @@
>  			};
>  
>  			ldo23_reg: LDO23 {
> -				regulator-name = "CAM_SEN_CORE_1.2V_AP";
> +				regulator-name = "CAM_SEN_CORE_1.05V_AP";
>  				regulator-min-microvolt = <1050000>;
> -				regulator-max-microvolt = <1200000>;
> +				regulator-max-microvolt = <1050000>;
>  			};
>  
>  			ldo24_reg: LDO24 {
> @@ -516,9 +516,10 @@
>  			};
>  
>  			ldo25_reg: LDO25 {
> -				regulator-name = "CAM_SEN_A2.8V_AP";
> +				regulator-name = "UNUSED_LDO25";
>  				regulator-min-microvolt = <2800000>;
>  				regulator-max-microvolt = <2800000>;
> +				regulator-always-off;

No. I mentioned in last email that this property is wrong.

When resubmitting, please fix the subject prefix.

Best regards,
Krzysztof

  reply	other threads:[~2017-01-06 12:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170106114119epcas5p2c29ea8c8118db4a1fb600970ea0dafd4@epcas5p2.samsung.com>
2017-01-06 11:41 ` [PATCH v4 0/5] Andi Shyti
     [not found]   ` <CGME20170106114120epcas5p21ed16e8f71152245f12fd00a8d73df0a@epcas5p2.samsung.com>
2017-01-06 11:41     ` [PATCH v4 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong values foe ldo23 and ldo25 Andi Shyti
2017-01-06 12:01       ` Krzysztof Kozlowski [this message]
2017-01-06 12:09       ` Javier Martinez Canillas
     [not found]   ` <CGME20170106114120epcas5p2dde13ec37b7e53f65b6899da9e7c7e60@epcas5p2.samsung.com>
2017-01-06 11:41     ` [PATCH v4 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Andi Shyti
2017-01-06 12:12       ` Krzysztof Kozlowski
2017-01-06 12:43       ` Javier Martinez Canillas
     [not found]   ` <CGME20170106114120epcas5p299b63311b3c55738537a40486f1462d8@epcas5p2.samsung.com>
2017-01-06 11:41     ` [PATCH v4 3/5] input: Add support for the tm2 touchkey device driver Andi Shyti
2017-01-06 12:15       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170106114120epcas5p26f09370d63026c8fbb64df049d2e2cfd@epcas5p2.samsung.com>
2017-01-06 11:41     ` [PATCH v4 4/5] input: tm2-touchkey: Add touchkey driver support for TM2 Andi Shyti
2017-01-06 12:16       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170106114121epcas5p26862de873ae8efb2102701c6ac452a6e@epcas5p2.samsung.com>
2017-01-06 11:41     ` [PATCH v4 5/5] arm64: dts: exynos: Add tm2 touchkey node Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170106120149.n2hak4vokip75pda@kozik-lap \
    --to=krzk@kernel.org \
    --cc=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=beomho.seo@samsung.com \
    --cc=catalin.marinas@arm.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=galaxyra@gmail.com \
    --cc=javier@osg.samsung.com \
    --cc=jcsing.lee@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).