* [PATCH 2/3] Input: pwm-beeper - switch to using managed resources
2017-01-06 18:20 [PATCH 1/3] Input: pwm-beeper - remove calls to legacy pwm_request API Dmitry Torokhov
@ 2017-01-06 18:20 ` Dmitry Torokhov
2017-01-07 4:01 ` David Lechner
2017-01-06 18:20 ` [PATCH 3/3] Input: pwm-beeper - use input_set_capability() Dmitry Torokhov
1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2017-01-06 18:20 UTC (permalink / raw)
To: linux-input; +Cc: Thierry Reding, linux-kernel, David Lechner
e of managed resources (devm) simplifies error handling and teardown
of the driver.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/pwm-beeper.c | 44 ++++++++++-------------------------------
1 file changed, 10 insertions(+), 34 deletions(-)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index cb87e475bd23..14c52054f5b7 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -95,18 +95,19 @@ static void pwm_beeper_close(struct input_dev *input)
static int pwm_beeper_probe(struct platform_device *pdev)
{
+ struct device *dev = &pdev->dev;
struct pwm_beeper *beeper;
int error;
- beeper = kzalloc(sizeof(*beeper), GFP_KERNEL);
+ beeper = devm_kzalloc(dev, sizeof(*beeper), GFP_KERNEL);
if (!beeper)
return -ENOMEM;
- beeper->pwm = pwm_get(&pdev->dev, NULL);
+ beeper->pwm = devm_pwm_get(dev, NULL);
if (IS_ERR(beeper->pwm)) {
error = PTR_ERR(beeper->pwm);
- dev_err(&pdev->dev, "Failed to request pwm device: %d\n", error);
- goto err_free;
+ dev_err(dev, "Failed to request pwm device: %d\n", error);
+ return error;
}
/*
@@ -117,13 +118,11 @@ static int pwm_beeper_probe(struct platform_device *pdev)
INIT_WORK(&beeper->work, pwm_beeper_work);
- beeper->input = input_allocate_device();
+ beeper->input = devm_input_allocate_device(dev);
if (!beeper->input) {
- dev_err(&pdev->dev, "Failed to allocate input device\n");
- error = -ENOMEM;
- goto err_pwm_free;
+ dev_err(dev, "Failed to allocate input device\n");
+ return -ENOMEM;
}
- beeper->input->dev.parent = &pdev->dev;
beeper->input->name = "pwm-beeper";
beeper->input->phys = "pwm/input0";
@@ -142,35 +141,13 @@ static int pwm_beeper_probe(struct platform_device *pdev)
error = input_register_device(beeper->input);
if (error) {
- dev_err(&pdev->dev, "Failed to register input device: %d\n", error);
- goto err_input_free;
+ dev_err(dev, "Failed to register input device: %d\n", error);
+ return error;
}
platform_set_drvdata(pdev, beeper);
return 0;
-
-err_input_free:
- input_free_device(beeper->input);
-err_pwm_free:
- pwm_free(beeper->pwm);
-err_free:
- kfree(beeper);
-
- return error;
-}
-
-static int pwm_beeper_remove(struct platform_device *pdev)
-{
- struct pwm_beeper *beeper = platform_get_drvdata(pdev);
-
- input_unregister_device(beeper->input);
-
- pwm_free(beeper->pwm);
-
- kfree(beeper);
-
- return 0;
}
static int __maybe_unused pwm_beeper_suspend(struct device *dev)
@@ -205,7 +182,6 @@ MODULE_DEVICE_TABLE(of, pwm_beeper_match);
static struct platform_driver pwm_beeper_driver = {
.probe = pwm_beeper_probe,
- .remove = pwm_beeper_remove,
.driver = {
.name = "pwm-beeper",
.pm = &pwm_beeper_pm_ops,
--
2.11.0.390.gc69c2f50cf-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] Input: pwm-beeper - use input_set_capability()
2017-01-06 18:20 [PATCH 1/3] Input: pwm-beeper - remove calls to legacy pwm_request API Dmitry Torokhov
2017-01-06 18:20 ` [PATCH 2/3] Input: pwm-beeper - switch to using managed resources Dmitry Torokhov
@ 2017-01-06 18:20 ` Dmitry Torokhov
2017-01-06 18:29 ` [PATCH 3/3 v2] " Dmitry Torokhov
1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2017-01-06 18:20 UTC (permalink / raw)
To: linux-input; +Cc: Thierry Reding, linux-kernel, David Lechner
Instead of manipulating capability bits directly, let's use
input_set_capability() API.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/pwm-beeper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index 14c52054f5b7..90e8eea8607d 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -131,8 +131,8 @@ static int pwm_beeper_probe(struct platform_device *pdev)
beeper->input->id.product = 0x0001;
beeper->input->id.version = 0x0100;
- beeper->input->evbit[0] = BIT(EV_SND);
- beeper->input->sndbit[0] = BIT(SND_TONE) | BIT(SND_BELL);
+ inptut_set_capability(beeper->input, EV_SND, SND_TONE);
+ inptut_set_capability(beeper->input, EV_SND, SND_BELL);
beeper->input->event = pwm_beeper_event;
beeper->input->close = pwm_beeper_close;
--
2.11.0.390.gc69c2f50cf-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread