From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Cameron Gutman <aicommander@gmail.com>
Cc: dan.g.tob@gmail.com, linux-input <linux-input@vger.kernel.org>,
Pavel Rojtberg <rojtberg@gmail.com>
Subject: Re: Bug in recent pad patch (96eb371b816c)
Date: Fri, 6 Jan 2017 10:34:12 -0800 [thread overview]
Message-ID: <20170106183412.GA4119@dtor-ws> (raw)
In-Reply-To: <69517E60-A1A3-4B2E-ABE3-B268CB5371E5@gmail.com>
On Fri, Jan 06, 2017 at 12:06:39PM -0600, Cameron Gutman wrote:
> It looks like the recent commit in master
>
> 96eb371b816c ("Input: xpad - correctly sort vendor id's")
>
> adds a duplicate entry for XPAD_XBOXONE_VENDOR(0x24c6).
>
> You may want to amend that with the following:
Thanks, I amended the offending commit.
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index ceb6a58..c06b717 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -325,7 +325,6 @@ static struct usb_device_id xpad_table[] = {
> XPAD_XBOX360_VENDOR(0x12ab), /* X-Box 360 dance pads */
> XPAD_XBOX360_VENDOR(0x1430), /* RedOctane X-Box 360 controllers */
> XPAD_XBOX360_VENDOR(0x146b), /* BigBen Interactive Controllers */
> - XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */
> XPAD_XBOX360_VENDOR(0x1532), /* Razer Sabertooth */
> XPAD_XBOX360_VENDOR(0x15e4), /* Numark X-Box 360 controllers */
> XPAD_XBOX360_VENDOR(0x162e), /* Joytech X-Box 360 controllers */
>
--
Dmitry
prev parent reply other threads:[~2017-01-06 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 18:06 Bug in recent pad patch (96eb371b816c) Cameron Gutman
2017-01-06 18:34 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106183412.GA4119@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aicommander@gmail.com \
--cc=dan.g.tob@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rojtberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).